> On 2011-11-29 10:06:50, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java, > > line 182 > > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line182> > > > > the file name will be oozie-user-hive-default.xml? > > Alejandro Abdelnur wrote: > On the HiveMain side is always this name, the HiveActionExecutor copies > with this name.
mentioning a typo of missing "user" in the xml file name. > On 2011-11-29 10:06:50, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java, > > line 241 > > <https://reviews.apache.org/r/2927/diff/1/?file=59987#file59987line241> > > > > is it parameter 'key' or 'value' ? Sounds 'key' or 'var' more > > appropriate. > > Alejandro Abdelnur wrote: > this is the hive action <param> thus it should be param Questioning about the text "Parameter value". Will it be "Parameter key" instead? - Mohammad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2927/#review3496 ----------------------------------------------------------- On 2011-11-29 18:24:19, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2927/ > ----------------------------------------------------------- > > (Updated 2011-11-29 18:24:19) > > > Review request for oozie. > > > Summary > ------- > > OOZIE-68 Add Hive Action > > > This addresses bug OOZIE-68. > https://issues.apache.org/jira/browse/OOZIE-68 > > > Diffs > ----- > > /trunk/.gitignore 1208002 > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1208002 > /trunk/client/src/main/resources/hive-action-0.2.xsd PRE-CREATION > /trunk/core/pom.xml 1208002 > /trunk/core/src/main/conf/oozie-site.xml 1208002 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1208002 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1208002 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitCommand.java > 1208002 > > /trunk/core/src/main/java/org/apache/oozie/service/LiteWorkflowAppService.java > 1208002 > /trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1208002 > > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/command/wf/TestSubmitCommand.java > 1208002 > > /trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1208002 > /trunk/core/src/test/resources/user-hive-default.xml PRE-CREATION > /trunk/docs/src/site/twiki/DG_HiveActionExtension.twiki PRE-CREATION > /trunk/docs/src/site/twiki/ENG_Building.twiki 1208002 > /trunk/docs/src/site/twiki/index.twiki 1208002 > /trunk/examples/pom.xml 1208002 > /trunk/examples/src/main/apps/hive/job.properties PRE-CREATION > /trunk/examples/src/main/apps/hive/my-hive-default.xml PRE-CREATION > /trunk/examples/src/main/apps/hive/script.q PRE-CREATION > /trunk/examples/src/main/apps/hive/workflow.xml PRE-CREATION > > /trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java > 1208002 > /trunk/pom.xml 1208002 > /trunk/sharelib/hive/pom.xml PRE-CREATION > /trunk/sharelib/pom.xml 1208002 > /trunk/src/main/assemblies/sharelib.xml 1208002 > > Diff: https://reviews.apache.org/r/2927/diff > > > Testing > ------- > > Note that hive testcases are excluded by default and to run the you have to > do: > > mvn -DtestHive -Dtest=TestHiveActionExecutor,TestHiveMain > > This is mentioned in the ENG_Building twiki. > > The reason for this is the dependency conflict between pig and hive regarding > antlr > > > Thanks, > > Alejandro > >
