----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2972/#review3592 -----------------------------------------------------------
/trunk/client/src/main/resources/sqoop-action-0.2.xsd <https://reviews.apache.org/r/2972/#comment8008> why move is not supported? /trunk/core/pom.xml <https://reviews.apache.org/r/2972/#comment8009> is this the only supported hadoop version? Will it work for any apache version? /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java <https://reviews.apache.org/r/2972/#comment8010> why does it return hive? /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java <https://reviews.apache.org/r/2972/#comment8011> is it really hive-site.xml ? /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java <https://reviews.apache.org/r/2972/#comment8012> please use try {}finally {os.close()} Same thing in multiple places of this file. /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki <https://reviews.apache.org/r/2972/#comment8013> </sqoop> --></command> /trunk/docs/src/site/twiki/index.twiki <https://reviews.apache.org/r/2972/#comment8014> extra line? - Mohammad On 2011-11-29 23:23:25, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2972/ > ----------------------------------------------------------- > > (Updated 2011-11-29 23:23:25) > > > Review request for oozie. > > > Summary > ------- > > Adding sqoop action > > > This addresses bug OOZIE-156. > https://issues.apache.org/jira/browse/OOZIE-156 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1208129 > /trunk/client/src/main/resources/sqoop-action-0.2.xsd PRE-CREATION > /trunk/core/pom.xml 1208129 > /trunk/core/src/main/conf/oozie-site.xml 1208129 > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 1208129 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > PRE-CREATION > /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki PRE-CREATION > /trunk/docs/src/site/twiki/ENG_Building.twiki 1208129 > /trunk/docs/src/site/twiki/index.twiki 1208129 > /trunk/examples/pom.xml 1208129 > /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.properties > PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.script PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/job.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/workflow.xml PRE-CREATION > /trunk/examples/src/main/apps/sqoop/db.hsqldb.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop/db.hsqldb.script PRE-CREATION > /trunk/examples/src/main/apps/sqoop/job.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop/workflow.xml PRE-CREATION > /trunk/pom.xml 1208129 > /trunk/sharelib/pom.xml 1208129 > /trunk/sharelib/sqoop/pom.xml PRE-CREATION > /trunk/src/main/assemblies/sharelib.xml 1208129 > > Diff: https://reviews.apache.org/r/2972/diff > > > Testing > ------- > > Similar to the hive action, a special profile must be used to run the sqoop > action testcase: > > $ mvn clean test -DtestSqoop -Dtest=TestSqoopActionExecutor > > > Thanks, > > Alejandro > >
