> On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/client/src/main/resources/sqoop-action-0.2.xsd, line 58 > > <https://reviews.apache.org/r/2972/diff/1/?file=60676#file60676line58> > > > > why move is not supported?
same as the prepare for all other actions, we are currently not supporting move there. > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/core/pom.xml, line 623 > > <https://reviews.apache.org/r/2972/diff/1/?file=60677#file60677line623> > > > > is this the only supported hadoop version? Will it work for any apache > > version? It will work with an apache version 0.23 onwards. > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java, > > line 124 > > <https://reviews.apache.org/r/2972/diff/1/?file=60680#file60680line124> > > > > why does it return hive? thanks for catching this. will fix. > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java, > > line 78 > > <https://reviews.apache.org/r/2972/diff/1/?file=60681#file60681line78> > > > > is it really hive-site.xml ? no, have to remove this, will fix. > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java, > > line 81 > > <https://reviews.apache.org/r/2972/diff/1/?file=60681#file60681line81> > > > > please use try {}finally {os.close()} > > Same thing in multiple places of this file. k > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki, line 62 > > <https://reviews.apache.org/r/2972/diff/1/?file=60683#file60683line62> > > > > </sqoop> --></command> will fix > On 2011-12-01 10:15:41, Mohammad Islam wrote: > > /trunk/docs/src/site/twiki/index.twiki, line 59 > > <https://reviews.apache.org/r/2972/diff/1/?file=60685#file60685line59> > > > > extra line? k - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2972/#review3592 ----------------------------------------------------------- On 2011-11-29 23:23:25, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2972/ > ----------------------------------------------------------- > > (Updated 2011-11-29 23:23:25) > > > Review request for oozie. > > > Summary > ------- > > Adding sqoop action > > > This addresses bug OOZIE-156. > https://issues.apache.org/jira/browse/OOZIE-156 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1208129 > /trunk/client/src/main/resources/sqoop-action-0.2.xsd PRE-CREATION > /trunk/core/pom.xml 1208129 > /trunk/core/src/main/conf/oozie-site.xml 1208129 > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 1208129 > > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > PRE-CREATION > /trunk/docs/src/site/twiki/DG_SqoopActionExtension.twiki PRE-CREATION > /trunk/docs/src/site/twiki/ENG_Building.twiki 1208129 > /trunk/docs/src/site/twiki/index.twiki 1208129 > /trunk/examples/pom.xml 1208129 > /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.properties > PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/db.hsqldb.script PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/job.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop-freeform/workflow.xml PRE-CREATION > /trunk/examples/src/main/apps/sqoop/db.hsqldb.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop/db.hsqldb.script PRE-CREATION > /trunk/examples/src/main/apps/sqoop/job.properties PRE-CREATION > /trunk/examples/src/main/apps/sqoop/workflow.xml PRE-CREATION > /trunk/pom.xml 1208129 > /trunk/sharelib/pom.xml 1208129 > /trunk/sharelib/sqoop/pom.xml PRE-CREATION > /trunk/src/main/assemblies/sharelib.xml 1208129 > > Diff: https://reviews.apache.org/r/2972/diff > > > Testing > ------- > > Similar to the hive action, a special profile must be used to run the sqoop > action testcase: > > $ mvn clean test -DtestSqoop -Dtest=TestSqoopActionExecutor > > > Thanks, > > Alejandro > >
