[
https://issues.apache.org/jira/browse/OOZIE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162637#comment-13162637
]
[email protected] commented on OOZIE-8:
---------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2997/#review3615
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
<https://reviews.apache.org/r/2997/#comment8070>
Can you move the else back to the previous line to conform with Java coding
convention?
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
<https://reviews.apache.org/r/2997/#comment8071>
Semantics are preserved.
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
<https://reviews.apache.org/r/2997/#comment8072>
I did not quite understand how iterating over populating a new
configuration with the entries in the conf is solving the problem. Can you
please explain?
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java
<https://reviews.apache.org/r/2997/#comment8073>
Can you please add comments on how the re-run code is being tested fore
replacing the job.properties values?
- Santhosh
On 2011-12-02 21:08:37, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2997/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-02 21:08:37)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In workflow rerun, the variable values defined in job.properties were not
getting replaced in the action configuration, causing a JA018 error. Required
to have the action configuration in the rerun code to update itself with the
values corresponding to the keys.
bq.
bq.
bq. This addresses bug OOZIE-8.
bq. https://issues.apache.org/jira/browse/OOZIE-8
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
1209673
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java
1209673
bq.
bq. Diff: https://reviews.apache.org/r/2997/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> variable not replaced in workflow rerun
> ---------------------------------------
>
> Key: OOZIE-8
> URL: https://issues.apache.org/jira/browse/OOZIE-8
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Labels: oozie, rerun
> Attachments: OOZIE-8.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> job.properties:
> hdfsDir=/user/strat_ci/yoozie_test
> inputDir=${hdfsDir}/input-data
> outputDir=${hdfsDir}/output-demo
> queueName=grideng
> in the original run, the Action Configuration replaces the variable:
> <configuration>
> <property>
> <name>mapred.input.dir</name>
> <value>/user/strat_ci/yoozie_test/output-demo/mapred_1</value>
> </property>
> <property>
> <name>mapred.output.dir</name>
> <value>/user/strat_ci/yoozie_test/output-demo/streaming</value>
> </property>
> <property>
> <name>mapred.job.queue.name</name>
> <value>grideng</value>
> </property>
> in rerun, the Action Configuration does not replace variable, therefore the
> action fails with error code JA018:
> <configuration>
> <property>
> <name>mapred.input.dir</name>
> <value>${hdfsDir}/output-demo/mapred_1</value>
> </property>
> <property>
> <name>mapred.output.dir</name>
> <value>${hdfsDir}/output-demo/streaming</value>
> </property>
> <property>
> <name>mapred.job.queue.name</name>
> <value>grideng</value>
> </property>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
