[
https://issues.apache.org/jira/browse/OOZIE-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164902#comment-13164902
]
[email protected] commented on OOZIE-8:
---------------------------------------------------
bq. On 2011-12-05 06:48:56, Santhosh Srinivasan wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java,
line 130
bq. > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line130>
bq. >
bq. > Can you move the else back to the previous line to conform with Java
coding convention?
done. Oozie formatting introduces this change. We need to update the formatter
bq. On 2011-12-05 06:48:56, Santhosh Srinivasan wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java,
line 143
bq. > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line143>
bq. >
bq. > Semantics are preserved.
done
bq. On 2011-12-05 06:48:56, Santhosh Srinivasan wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java,
line 145
bq. > <https://reviews.apache.org/r/2997/diff/1/?file=61775#file61775line145>
bq. >
bq. > I did not quite understand how iterating over populating a new
configuration with the entries in the conf is solving the problem. Can you
please explain?
addressed as comments above the code change
bq. On 2011-12-05 06:48:56, Santhosh Srinivasan wrote:
bq. >
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java,
line 67
bq. > <https://reviews.apache.org/r/2997/diff/1/?file=61776#file61776line67>
bq. >
bq. > Can you please add comments on how the re-run code is being tested
fore replacing the job.properties values?
testcase updated for clarity
- Mona
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2997/#review3615
-----------------------------------------------------------
On 2011-12-08 01:18:05, Mona Chitnis wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2997/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-08 01:18:05)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In workflow rerun, parametrized variables were not getting replaced with
values in the action configuration, causing a JA018 error. Therefore it is
required to have the action configuration in the rerun code to update itself
with the values corresponding to the keys.
bq.
bq.
bq. This addresses bug OOZIE-8.
bq. https://issues.apache.org/jira/browse/OOZIE-8
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
1210771
bq.
trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java
1210771
bq. trunk/core/src/test/resources/rerun-varsub-wf.xml PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/2997/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. yes
bq.
bq.
bq. Thanks,
bq.
bq. Mona
bq.
bq.
> variable not replaced in workflow rerun
> ---------------------------------------
>
> Key: OOZIE-8
> URL: https://issues.apache.org/jira/browse/OOZIE-8
> Project: Oozie
> Issue Type: Bug
> Reporter: Mona Chitnis
> Labels: oozie, rerun
> Attachments: OOZIE-8.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> job.properties:
> hdfsDir=/user/strat_ci/yoozie_test
> inputDir=${hdfsDir}/input-data
> outputDir=${hdfsDir}/output-demo
> queueName=grideng
> in the original run, the Action Configuration replaces the variable:
> <configuration>
> <property>
> <name>mapred.input.dir</name>
> <value>/user/strat_ci/yoozie_test/output-demo/mapred_1</value>
> </property>
> <property>
> <name>mapred.output.dir</name>
> <value>/user/strat_ci/yoozie_test/output-demo/streaming</value>
> </property>
> <property>
> <name>mapred.job.queue.name</name>
> <value>grideng</value>
> </property>
> in rerun, the Action Configuration does not replace variable, therefore the
> action fails with error code JA018:
> <configuration>
> <property>
> <name>mapred.input.dir</name>
> <value>${hdfsDir}/output-demo/mapred_1</value>
> </property>
> <property>
> <name>mapred.output.dir</name>
> <value>${hdfsDir}/output-demo/streaming</value>
> </property>
> <property>
> <name>mapred.job.queue.name</name>
> <value>grideng</value>
> </property>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
