[
https://issues.apache.org/jira/browse/OOZIE-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13163104#comment-13163104
]
[email protected] commented on OOZIE-578:
-----------------------------------------------------
bq. On 2011-12-05 18:40:43, Alejandro Abdelnur wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/shell-action-0.1.xsd,
line 34
bq. > <https://reviews.apache.org/r/3000/diff/2/?file=61824#file61824line34>
bq. >
bq. > env vars setting is missing, this is quite important when using
shells.
bq. >
bq. > we should be able to specify multiple ENV vars, with one of the two
syntaxes:
bq. >
bq. > <env-var>VAR=VALUE</env-var>
bq. >
bq. > or
bq. >
bq. > <environment>
bq. > <variable>
bq. > <name>VALUE</name>
bq. > <value>VALUE</value>
bq. > </variable>
bq. > </environment>
bq. >
bq.
bq. Mohammad Islam wrote:
bq. I considered that also an option. So user can specify it here and
oozie will add it to oozie.launcher.mapred.child.env.
bq. I will add that.
bq. In addition, currently, User could still add the env directly through
oozie.launcher.mapred.child.env.
bq.
bq. Alejandro Abdelnur wrote:
bq. I don't think these ENV settings should affect the launcher ENV, these
ENV settings are exclusively for the SHELL it will be executed by the launcher.
bq.
bq. If the user wants to alter the launcher ENV for some reason, they
always can do it with the oozie.launcher.mapred.child.env, but by definition,
anything that is oozie.launcher.* is not propagated to the action itself.
bq.
bq. Mohammad Islam wrote:
bq. My use case is as follows:
bq. 1. <file>myscr.sh</file>
bq. 2. <exec>myscr.sh<exec>
bq.
bq. In this case, if Oozie LM executes the command, it will not find the
executable "myscr.sh" because PATH variable doesn't contain CWD(.).
bq. However, if it is like <exec>./myscr.sh<exec>, it will work. That
means user has to give the full path of the executable. How can a user
configure this through PATH variable.
bq.
bq.
bq. Alejandro Abdelnur wrote:
bq. well adding current dir to launcher process path PATH would do. just
that.
bq.
bq. but still i'd argue that unix users are use to do the ./SCRIPT thingy
as current dir is commonly not in the PATH.
bq.
bq. Else, we could in the ShellMain to look at the script name and if does
not start with './' prepend it
bq.
bq. Mohammad Islam wrote:
bq. It is not always current dir in the path. It could be <archive> that
could expand to a different directory. So in that case, the exec will be
<MY_TAR>/script.sh. So pre-appending might not work.
bq.
bq.
bq. Another thing, in addition to PATH, do we need to add LD_LIBRARY_PATH
(for C++ exec), java.library.path(for java exec). I didn't test those use-cases.
bq.
bq. So I will add **only** PATH to child.env. Others, I will check.
bq.
bq. Otherwise all env should be pass through <environment> section.
bq. For implementation, what is the best way of passing these
env/variables. Can think of the followings:
bq. Option 1: Use the same concept of args. For example args.0=var1,
args.1=value1, etc...
bq. Option 2: Pass the whole environment section as value and parse it in
the ShellMain. (Not a good approach)
bq.
bq.
if yo are using archive, the path is not the TAR name but the the directory in
the expanded TAR, as the expansion happens in CWD, the './' should work. What
am I missing here?
For ENV passing, it should be one element per VAR, you don't want to get into
parsing there.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3000/#review3624
-----------------------------------------------------------
On 2011-12-04 08:05:24, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3000/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-04 08:05:24)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. More context at JIRA OOZIE-578.
bq.
bq.
bq. This addresses bug OOZIE-578.
bq. https://issues.apache.org/jira/browse/OOZIE-578
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/shell-action-0.1.xsd
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/DG_ShellActionExtension.twiki
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/index.twiki
1209346
bq.
bq. Diff: https://reviews.apache.org/r/3000/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Support shell action in Oozie WF
> --------------------------------
>
> Key: OOZIE-578
> URL: https://issues.apache.org/jira/browse/OOZIE-578
> Project: Oozie
> Issue Type: New Feature
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> Running a script (shell/perl/python/?) from a workflow is a very common
> use-case. Currently, Oozie user needs to write a custom java code to execute
> the script which is not convenient.
> This JIRA is to discuss the feasibility and scope of the feature. The
> proposed design of this feature will also be included.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
