[
https://issues.apache.org/jira/browse/OOZIE-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164238#comment-13164238
]
[email protected] commented on OOZIE-578:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3000/#review3694
-----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
<https://reviews.apache.org/r/3000/#comment8245>
good idea. will do that.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
<https://reviews.apache.org/r/3000/#comment8246>
ok
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
<https://reviews.apache.org/r/3000/#comment8265>
This is very tricky thing.
First the executable path is determined by the environment of the launching
process.
The environment that we pass to exec command is passed as an environment of
the spawned process. Not used to find the process itself. LM's environment's
path is used to the executable path.
I tested it.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
<https://reviews.apache.org/r/3000/#comment8247>
will remove.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8248>
ok
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8249>
will remove all commented code
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8251>
ok
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8252>
if it is returned from the method, then no need to test.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8250>
ok
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8253>
will remove the duplicate methods
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8254>
ok
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8256>
so parsing will be done twice.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8257>
This one is used in line 81
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8258>
good catch
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
<https://reviews.apache.org/r/3000/#comment8259>
correct
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/3000/#comment8260>
I want shell , email action to be top level by default.
The user will need to configure so many things, if not using our
oozie-site.xml
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
<https://reviews.apache.org/r/3000/#comment8261>
The same is true here. So many extra configurations those are candidate for
default settings. We need to change our default stuffs.
- Mohammad
On 2011-12-07 00:51:10, Mohammad Islam wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3000/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 00:51:10)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. More context at JIRA OOZIE-578.
bq.
bq.
bq. This addresses bug OOZIE-578.
bq. https://issues.apache.org/jira/browse/OOZIE-578
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/index.twiki
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/DG_ShellActionExtension.twiki
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
1209346
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/shell-action-0.1.xsd
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
1209346
bq.
bq. Diff: https://reviews.apache.org/r/3000/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Mohammad
bq.
bq.
> Support shell action in Oozie WF
> --------------------------------
>
> Key: OOZIE-578
> URL: https://issues.apache.org/jira/browse/OOZIE-578
> Project: Oozie
> Issue Type: New Feature
> Reporter: Mohammad Kamrul Islam
> Assignee: Mohammad Kamrul Islam
>
> Running a script (shell/perl/python/?) from a workflow is a very common
> use-case. Currently, Oozie user needs to write a custom java code to execute
> the script which is not convenient.
> This JIRA is to discuss the feasibility and scope of the feature. The
> proposed design of this feature will also be included.
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
