----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3039/#review3677 -----------------------------------------------------------
Please test building a distribution and running the examples as testcases don't test actual sharelib usage (the JARs are in the testclasspath already) trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3039/#comment8185> The JIRA states that action JARs have precedence over the oozie lib JARs but the logic here is the other way around. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3039/#comment8186> this is not an actionsharelib, the method should be renamed to addShareLib trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3039/#comment8187> the action sharelib should be added outside of this method. trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/3039/#comment8188> is the oozie sharelib always added and the action sharelibs only if the USE_SYSTEM_LIBPATH is set? this is kind of confusing. trunk/release-log.txt <https://reviews.apache.org/r/3039/#comment8182> the patch should not modify the release-log.txt file, this should be done by the committer. - Alejandro On 2011-12-06 22:15:07, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3039/ > ----------------------------------------------------------- > > (Updated 2011-12-06 22:15:07) > > > Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro > Abdelnur. > > > Summary > ------- > > Add libraries which can be used by all actions in oozie > > https://issues.apache.org/jira/browse/OOZIE-628 > > > This addresses bug OOZIE-628. > https://issues.apache.org/jira/browse/OOZIE-628 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1211066 > trunk/release-log.txt 1211066 > > Diff: https://reviews.apache.org/r/3039/diff > > > Testing > ------- > > Tested against current test cases > > > Thanks, > > Virag > >
