> On 2011-12-06 22:31:44, Alejandro Abdelnur wrote: > > Please test building a distribution and running the examples as testcases > > don't test actual sharelib usage (the JARs are in the testclasspath already)
ok > On 2011-12-06 22:31:44, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 437 > > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line437> > > > > the action sharelib should be added outside of this method. ok > On 2011-12-06 22:31:44, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 438 > > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line438> > > > > is the oozie sharelib always added and the action sharelibs only if > > the USE_SYSTEM_LIBPATH is set? > > > > this is kind of confusing. Yes, Oozie Sharelibs which are common to all actions will always be added. Action share libs will only be added if use_system_libpath is set to true. > On 2011-12-06 22:31:44, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 428 > > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line428> > > > > this is not an actionsharelib, the method should be renamed to > > addShareLib ok > On 2011-12-06 22:31:44, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 425 > > <https://reviews.apache.org/r/3039/diff/1/?file=62631#file62631line425> > > > > The JIRA states that action JARs have precedence over the oozie lib > > JARs but the logic here is the other way around. good catch, will change the logic - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3039/#review3677 ----------------------------------------------------------- On 2011-12-06 22:15:07, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3039/ > ----------------------------------------------------------- > > (Updated 2011-12-06 22:15:07) > > > Review request for oozie, Mohammad Islam, Angelo K. Huang, and Alejandro > Abdelnur. > > > Summary > ------- > > Add libraries which can be used by all actions in oozie > > https://issues.apache.org/jira/browse/OOZIE-628 > > > This addresses bug OOZIE-628. > https://issues.apache.org/jira/browse/OOZIE-628 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1211066 > trunk/release-log.txt 1211066 > > Diff: https://reviews.apache.org/r/3039/diff > > > Testing > ------- > > Tested against current test cases > > > Thanks, > > Virag > >
