-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3018/
-----------------------------------------------------------
(Updated 2011-12-08 04:13:55.406000)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
reviewer comments incorporated. changed the function
checkMultipleTimeInstances() to use variables instead of repeated calls to
fetch the xml children nodes, and adjusted the unit test to check for input and
output events separately.
Summary
-------
For the coordinator input events, if there are multiple dates, it uses the
first date to resolve the data
instance, instead of giving warning or error.
For example:
<data-in name="din1" dataset="ds1">
<instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance>
</data-in>
Similarly for output events.
This patch will give error for the above case and protect against submission of
job that defaults to the first date without the knowledge of user.
This addresses bug OOZIE-15.
https://issues.apache.org/jira/browse/OOZIE-15
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1209756
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1209756
Diff: https://reviews.apache.org/r/3018/diff
Testing
-------
yes
Thanks,
Mona
