----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3018/#review3737 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3018/#comment8426> In general, element name could start with with "e". so in this case, you could use eJob or eCoordJob to make it more meaning full. However, this is minor thing. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3018/#comment8429> I know it is not the scope of this JIRA. Bit it could relevan and could be added into this JIRA too. For example instance.trim().length() == 0 --> means instance content is empty. Are we checking this error case. If we do it other place, then it is fine. If not, we could catch it here and throw appropriate Exception or we could create a new JIRA for that. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3018/#comment8427> is there any possibility that instance could be "null". In that case adding one more && condition would not hurt. trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java <https://reviews.apache.org/r/3018/#comment8428> Since both code sections for input-events and output-events are identical, we should write a generic method and call it with twice. Only variables are eventName="input-events"/output-events" and instance description "data-in"/ data-output". Rest of the code ae common. So we could parameterize the above two variables into the new method. - Mohammad On 2011-12-08 04:13:55, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3018/ > ----------------------------------------------------------- > > (Updated 2011-12-08 04:13:55) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > For the coordinator input events, if there are multiple dates, it uses the > first date to resolve the data > instance, instead of giving warning or error. > For example: > <data-in name="din1" dataset="ds1"> > <instance>2010-06-11T00:30Z,2010-06-11T00:31Z,2010-06-11T00:32Z</instance> > </data-in> > > Similarly for output events. > > This patch will give error for the above case and protect against submission > of job that defaults to the first date without the knowledge of user. > > > This addresses bug OOZIE-15. > https://issues.apache.org/jira/browse/OOZIE-15 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 1209756 > > trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 1209756 > > Diff: https://reviews.apache.org/r/3018/diff > > > Testing > ------- > > yes > > > Thanks, > > Mona > >
