[
https://issues.apache.org/jira/browse/OOZIE-578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165663#comment-13165663
] [email protected] commented on OOZIE-578: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3000/#review3758 ----------------------------------------------------------- http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java <https://reviews.apache.org/r/3000/#comment8494> there are many javadocs through out the patch with: * incorrect/non-existing params * no description for the params/return/exception http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java <https://reviews.apache.org/r/3000/#comment8496> The action.xml file patch (which comes as a system property to the main class) should be set as an ENV variable to invoked shell http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java <https://reviews.apache.org/r/3000/#comment8491> typo 'environment' http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java <https://reviews.apache.org/r/3000/#comment8492> The print should be KEY=VALUE instead of :KEY::VALUE: http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java <https://reviews.apache.org/r/3000/#comment8493> why do we print the commands here, they are printed in the previous method 'printCommand; http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java <https://reviews.apache.org/r/3000/#comment8495> capture output is not being tested http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/DG_ShellActionExtension.twiki <https://reviews.apache.org/r/3000/#comment8497> the example is correct, it would just seem more appropriate to use a perl/sh invocation. - Alejandro On 2011-12-08 10:08:48, Mohammad Islam wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/3000/ bq. ----------------------------------------------------------- bq. bq. (Updated 2011-12-08 10:08:48) bq. bq. bq. Review request for oozie. bq. bq. bq. Summary bq. ------- bq. bq. More context at JIRA OOZIE-578. bq. bq. bq. This addresses bug OOZIE-578. bq. https://issues.apache.org/jira/browse/OOZIE-578 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1209346 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/shell-action-0.1.xsd PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml 1209346 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1209346 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/DG_ShellActionExtension.twiki PRE-CREATION bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/index.twiki 1209346 bq. bq. Diff: https://reviews.apache.org/r/3000/diff bq. bq. bq. Testing bq. ------- bq. bq. bq. Thanks, bq. bq. Mohammad bq. bq. > Support shell action in Oozie WF > -------------------------------- > > Key: OOZIE-578 > URL: https://issues.apache.org/jira/browse/OOZIE-578 > Project: Oozie > Issue Type: New Feature > Reporter: Mohammad Kamrul Islam > Assignee: Mohammad Kamrul Islam > > Running a script (shell/perl/python/?) from a workflow is a very common > use-case. Currently, Oozie user needs to write a custom java code to execute > the script which is not convenient. > This JIRA is to discuss the feasibility and scope of the feature. The > proposed design of this feature will also be included. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
