----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3222/#review3953 -----------------------------------------------------------
Nice work. branches-old/ap-pages/pom.xml <https://reviews.apache.org/r/3222/#comment8924> Incorrect indentation. Plust sll indentation has TABs, they must be spaces and 4 of them per indent. branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8925> s/customers/users/ branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8926> The warning about Mac/Windows, you really mean Mac? What tweaks are required? Asking because I'm not aware (and I develop Oozie on Mac ;) branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8927> s/reduer/reducer/ branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8929> How about having a paragraph explaining that all the following directories and files are created in the local filesystem and once all them are ready they are copied to HDFS. branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8930> actually, the job.properties file does not need to go to HDFS. it is always used from local filesystem (we should mention that) branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8931> It would be good to explain that any variable used (${VAR}) in the WF.XML must be a valid Java identifier (more specifically, no DOTs in the name). If a variable has a DOT in the name then instead using ${VAR} the ${wf:conf('VAR')} function must be used. branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8932> mention that the JAR with the custom IF class must be placed in the WF lib/ directory branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm <https://reviews.apache.org/r/3222/#comment8933> add a comment stating that the symlink name cannot be a multi level path, it must a be a name (no '/' in it). This means that the symlinks are always in the CWD - Alejandro On 2011-12-16 08:53:19, params wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3222/ > ----------------------------------------------------------- > > (Updated 2011-12-16 08:53:19) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > OOZIE-641: Documentation - Cookbook for using Map-Reduce with Oozie > > Summary: > https://issues.apache.org/jira/browse/OOZIE-641 > > Changes: > - pom.xml has been changed to fix the issue in APT where parser fails while > evaluating "${..}". The pom file does the post-processing of $. -> $. > - added a new .apt source file for map-reduce cookbook. > > Pending: > - The overall organization of all documents (sitemap for documentation) has > to be discussed. > - Some external links referenced in this new document will be available > later. Might have to merge/integrate with other existing documentation. > > > This addresses bug OOZIE-641. > https://issues.apache.org/jira/browse/OOZIE-641 > > > Diffs > ----- > > branches-old/ap-pages/pom.xml 1171233 > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm PRE-CREATION > branches-old/ap-pages/src/site/apt/quick-start.apt.vm 1171233 > branches-old/ap-pages/src/site/resources/images/DG_Overview.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/Launcher.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/MR-Dag-WF.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/job-config.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc1.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc2.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc3.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc4.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc5.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc6.png UNKNOWN > > Diff: https://reviews.apache.org/r/3222/diff > > > Testing > ------- > > NA > > > Thanks, > > params > >
