> On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/pom.xml, line 61 > > <https://reviews.apache.org/r/3222/diff/2/?file=64902#file64902line61> > > > > Incorrect indentation. Plust sll indentation has TABs, they must be > > spaces and 4 of them per indent.
aligned some mis-placed indents. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 23 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line23> > > > > The warning about Mac/Windows, you really mean Mac? What tweaks are > > required? Asking because I'm not aware (and I develop Oozie on Mac ;) Removed it, will retain the statement as "assuming GNU/Linux ...". > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 145 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line145> > > > > s/reduer/reducer/ Fixed. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 20 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line20> > > > > s/customers/users/ Fixed. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 196 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line196> > > > > actually, the job.properties file does not need to go to HDFS. it is > > always used from local filesystem (we should mention that) Added a statement here about this. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 254 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line254> > > > > It would be good to explain that any variable used (${VAR}) in the > > WF.XML must be a valid Java identifier (more specifically, no DOTs in the > > name). If a variable has a DOT in the name then instead using ${VAR} the > > ${wf:conf('VAR')} function must be used. Thanks for pointing that out. Added a brief note here. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 692 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line692> > > > > add a comment stating that the symlink name cannot be a multi level > > path, it must a be a name (no '/' in it). This means that the symlinks are > > always in the CWD Added a comment. > On 2011-12-16 21:54:46, Alejandro Abdelnur wrote: > > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 160 > > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line160> > > > > How about having a paragraph explaining that all the following > > directories and files are created in the local filesystem and once all them > > are ready they are copied to HDFS. Added a statement to emphasize this. - params ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3222/#review3953 ----------------------------------------------------------- On 2011-12-16 08:53:19, params wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3222/ > ----------------------------------------------------------- > > (Updated 2011-12-16 08:53:19) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > OOZIE-641: Documentation - Cookbook for using Map-Reduce with Oozie > > Summary: > https://issues.apache.org/jira/browse/OOZIE-641 > > Changes: > - pom.xml has been changed to fix the issue in APT where parser fails while > evaluating "${..}". The pom file does the post-processing of $. -> $. > - added a new .apt source file for map-reduce cookbook. > > Pending: > - The overall organization of all documents (sitemap for documentation) has > to be discussed. > - Some external links referenced in this new document will be available > later. Might have to merge/integrate with other existing documentation. > > > This addresses bug OOZIE-641. > https://issues.apache.org/jira/browse/OOZIE-641 > > > Diffs > ----- > > branches-old/ap-pages/pom.xml 1171233 > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm PRE-CREATION > branches-old/ap-pages/src/site/apt/quick-start.apt.vm 1171233 > branches-old/ap-pages/src/site/resources/images/DG_Overview.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/Launcher.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/MR-Dag-WF.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/job-config.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc1.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc2.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc3.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc4.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc5.png UNKNOWN > branches-old/ap-pages/src/site/resources/images/wc6.png UNKNOWN > > Diff: https://reviews.apache.org/r/3222/diff > > > Testing > ------- > > NA > > > Thanks, > > params > >
