[
https://issues.apache.org/jira/browse/OOZIE-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171233#comment-13171233
]
[email protected] commented on OOZIE-641:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3222/#review3953
-----------------------------------------------------------
Nice work.
branches-old/ap-pages/pom.xml
<https://reviews.apache.org/r/3222/#comment8924>
Incorrect indentation. Plust sll indentation has TABs, they must be spaces
and 4 of them per indent.
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8925>
s/customers/users/
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8926>
The warning about Mac/Windows, you really mean Mac? What tweaks are
required? Asking because I'm not aware (and I develop Oozie on Mac ;)
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8927>
s/reduer/reducer/
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8929>
How about having a paragraph explaining that all the following directories
and files are created in the local filesystem and once all them are ready they
are copied to HDFS.
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8930>
actually, the job.properties file does not need to go to HDFS. it is always
used from local filesystem (we should mention that)
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8931>
It would be good to explain that any variable used (${VAR}) in the WF.XML
must be a valid Java identifier (more specifically, no DOTs in the name). If a
variable has a DOT in the name then instead using ${VAR} the ${wf:conf('VAR')}
function must be used.
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8932>
mention that the JAR with the custom IF class must be placed in the WF lib/
directory
branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
<https://reviews.apache.org/r/3222/#comment8933>
add a comment stating that the symlink name cannot be a multi level path,
it must a be a name (no '/' in it). This means that the symlinks are always in
the CWD
- Alejandro
On 2011-12-16 08:53:19, params wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3222/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-16 08:53:19)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. OOZIE-641: Documentation - Cookbook for using Map-Reduce with Oozie
bq.
bq. Summary:
bq. https://issues.apache.org/jira/browse/OOZIE-641
bq.
bq. Changes:
bq. - pom.xml has been changed to fix the issue in APT where parser fails
while evaluating "${..}". The pom file does the post-processing of $. -> $.
bq. - added a new .apt source file for map-reduce cookbook.
bq.
bq. Pending:
bq. - The overall organization of all documents (sitemap for documentation)
has to be discussed.
bq. - Some external links referenced in this new document will be available
later. Might have to merge/integrate with other existing documentation.
bq.
bq.
bq. This addresses bug OOZIE-641.
bq. https://issues.apache.org/jira/browse/OOZIE-641
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. branches-old/ap-pages/pom.xml 1171233
bq. branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm
PRE-CREATION
bq. branches-old/ap-pages/src/site/apt/quick-start.apt.vm 1171233
bq. branches-old/ap-pages/src/site/resources/images/DG_Overview.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/Launcher.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/MR-Dag-WF.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/job-config.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc1.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc2.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc3.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc4.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc5.png UNKNOWN
bq. branches-old/ap-pages/src/site/resources/images/wc6.png UNKNOWN
bq.
bq. Diff: https://reviews.apache.org/r/3222/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. NA
bq.
bq.
bq. Thanks,
bq.
bq. params
bq.
bq.
> Documentation: Cookbook for using Map-Reduce with Oozie
> -------------------------------------------------------
>
> Key: OOZIE-641
> URL: https://issues.apache.org/jira/browse/OOZIE-641
> Project: Oozie
> Issue Type: Task
> Reporter: Parameswaran Raman
>
> Document that will serve as a cookbook for customers who will install, use
> and operate Oozie. This will be referenced from the main page - index.html.
> APT, the document tool will be used to create the document.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira