[ 
https://issues.apache.org/jira/browse/OOZIE-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172593#comment-13172593
 ] 

[email protected] commented on OOZIE-641:
-----------------------------------------------------



bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/pom.xml, line 61
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64902#file64902line61>
bq.  >
bq.  >     Incorrect indentation. Plust sll indentation has TABs, they must be 
spaces and 4 of them per indent.

aligned some mis-placed indents.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 23
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line23>
bq.  >
bq.  >     The warning about Mac/Windows, you really mean Mac? What tweaks are 
required? Asking because I'm not aware (and I develop Oozie on Mac ;)

Removed it, will retain the statement as "assuming GNU/Linux ...".


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 145
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line145>
bq.  >
bq.  >     s/reduer/reducer/

Fixed.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 20
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line20>
bq.  >
bq.  >     s/customers/users/

Fixed.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 196
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line196>
bq.  >
bq.  >     actually, the job.properties file does not need to go to HDFS. it is 
always used from local filesystem (we should mention that)

Added a statement here about this.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 254
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line254>
bq.  >
bq.  >     It would be good to explain that any variable used (${VAR}) in the 
WF.XML must be a valid Java identifier (more specifically, no DOTs in the 
name). If a variable has a DOT in the name then instead using ${VAR} the 
${wf:conf('VAR')} function must be used.

Thanks for pointing that out. Added a brief note here.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 692
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line692>
bq.  >
bq.  >     add a comment stating that the symlink name cannot be a multi level 
path, it must a be a name (no '/' in it). This means that the symlinks are 
always in the CWD

Added a comment.


bq.  On 2011-12-16 21:54:46, Alejandro Abdelnur wrote:
bq.  > branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm, line 160
bq.  > <https://reviews.apache.org/r/3222/diff/2/?file=64903#file64903line160>
bq.  >
bq.  >     How about having a paragraph explaining that all the following 
directories and files are created in the local filesystem and once all them are 
ready they are copied to HDFS.

Added a statement to emphasize this.


- params


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3222/#review3953
-----------------------------------------------------------


On 2011-12-16 08:53:19, params wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3222/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-16 08:53:19)
bq.  
bq.  
bq.  Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  OOZIE-641:  Documentation - Cookbook for using Map-Reduce with Oozie
bq.  
bq.  Summary:
bq.  https://issues.apache.org/jira/browse/OOZIE-641
bq.  
bq.  Changes:
bq.  - pom.xml has been changed to fix the issue in APT where parser fails 
while evaluating "${..}". The pom file does the post-processing of $. -> $.
bq.  - added a new .apt source file for map-reduce cookbook. 
bq.  
bq.  Pending:
bq.  - The overall organization of all documents (sitemap for documentation) 
has to be discussed.
bq.  - Some external links referenced in this new document will be available 
later. Might have to merge/integrate with other existing documentation.
bq.  
bq.  
bq.  This addresses bug OOZIE-641.
bq.      https://issues.apache.org/jira/browse/OOZIE-641
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    branches-old/ap-pages/pom.xml 1171233 
bq.    branches-old/ap-pages/src/site/apt/map-reduce-cookbook.apt.vm 
PRE-CREATION 
bq.    branches-old/ap-pages/src/site/apt/quick-start.apt.vm 1171233 
bq.    branches-old/ap-pages/src/site/resources/images/DG_Overview.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/Launcher.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/MR-Dag-WF.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/job-config.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc1.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc2.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc3.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc4.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc5.png UNKNOWN 
bq.    branches-old/ap-pages/src/site/resources/images/wc6.png UNKNOWN 
bq.  
bq.  Diff: https://reviews.apache.org/r/3222/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  NA
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  params
bq.  
bq.


                
> Documentation: Cookbook for using Map-Reduce with Oozie
> -------------------------------------------------------
>
>                 Key: OOZIE-641
>                 URL: https://issues.apache.org/jira/browse/OOZIE-641
>             Project: Oozie
>          Issue Type: Task
>            Reporter: Parameswaran Raman
>
> Document that will serve as a cookbook for customers who will install, use 
> and operate Oozie. This will be referenced from the main page - index.html.
> APT, the document tool will be used to create the document.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to