[ 
https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183391#comment-13183391
 ] 

[email protected] commented on OOZIE-651:
-----------------------------------------------------



bq.  On 2012-01-10 03:23:10, Mohamed Battisha wrote:
bq.  > any reasons for moving the list methods from the CoordRerunXCommand to 
the CoordUtility 
bq.  > it seems to be very related to the rerun command

These methods are being used by rerun command but very similar list methods 
also exist for retrieving logs for date and action range. So already there is 
some repetition of these functions. As they are generic methods for parsing 
date and action ranges, have moved them to the utility class.


- Virag


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4290
-----------------------------------------------------------


On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3441/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 02:05:54)
bq.  
bq.  
bq.  Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/OOZIE-651
bq.  
bq.  
bq.  This addresses bug OOZIE-651.
bq.      https://issues.apache.org/jira/browse/OOZIE-651
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 
1229389 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java 
1229389 
bq.    trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389 
bq.    trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java 
1229389 
bq.    trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 
1229389 
bq.    
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java 
1229389 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java
 1229389 
bq.    trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java 
PRE-CREATION 
bq.    trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389 
bq.  
bq.  Diff: https://reviews.apache.org/r/3441/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Tested against current test cases
bq.  Test cases for CoordUtils added
bq.  Ran the coordinator rerun example
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Virag
bq.  
bq.


                
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
>                 Key: OOZIE-651
>                 URL: https://issues.apache.org/jira/browse/OOZIE-651
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope, 
> Boolean.valueOf(refresh),
>                     Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it 
> executes. If it cant get the lock, then it is queued. In this case the return 
> value, the coordInfo, is null. Trying to access the coordInfo causes NPE in 
> such a case.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to