[
https://issues.apache.org/jira/browse/OOZIE-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184748#comment-13184748
]
[email protected] commented on OOZIE-651:
-----------------------------------------------------
bq. On 2012-01-12 03:18:42, Mohamed Battisha wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java, line 65
bq. > <https://reviews.apache.org/r/3441/diff/1/?file=67422#file67422line65>
bq. >
bq. > I am assuming this is just copy and paste from the rerunXCommand
getCoordActionsFromIds() is copy and paste, getCoordActionsFromDates() has been
refactored a bit to use logic from CoordActionsInDateRange class.
bq. On 2012-01-12 03:18:42, Mohamed Battisha wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java,
line 460
bq. > <https://reviews.apache.org/r/3441/diff/1/?file=67421#file67421line460>
bq. >
bq. > what if a null coordActions is returned. you may end up with NPE
Nope.. ParamChecker.null() has been added in the next function accessing
coordActions
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3441/#review4325
-----------------------------------------------------------
On 2012-01-10 02:05:54, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3441/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 02:05:54)
bq.
bq.
bq. Review request for oozie, Mohammad Islam and Angelo K. Huang.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. This addresses bug OOZIE-651.
bq. https://issues.apache.org/jira/browse/OOZIE-651
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java
1229389
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordRerunXCommand.java
1229389
bq. trunk/core/src/main/java/org/apache/oozie/coord/CoordUtils.java 1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/JobServlet.java
1229389
bq. trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java
1229389
bq.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
1229389
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java
1229389
bq. trunk/core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java
PRE-CREATION
bq. trunk/docs/src/site/twiki/DG_CoordinatorRerun.twiki 1229389
bq.
bq. Diff: https://reviews.apache.org/r/3441/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested against current test cases
bq. Test cases for CoordUtils added
bq. Ran the coordinator rerun example
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> Coordinator rerun fails due to NPE in some cases
> ------------------------------------------------
>
> Key: OOZIE-651
> URL: https://issues.apache.org/jira/browse/OOZIE-651
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> CoordinatorActionInfo coordInfo = coordEngine.reRun(jobId, rerunType, scope,
> Boolean.valueOf(refresh),
> Boolean.valueOf(noCleanup));
> coordActions = coordInfo.getCoordActions();
> The Coordinator rerun command requires to acquire the lock before it
> executes. If it cant get the lock, then it is queued. In this case the return
> value, the coordInfo, is null. Trying to access the coordInfo causes NPE in
> such a case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
