> On 2012-02-02 18:54:41, Alejandro Abdelnur wrote: > > trunk/core/src/main/resources/oozie-default.xml, line 1519 > > <https://reviews.apache.org/r/3738/diff/1/?file=71881#file71881line1519> > > > > the default value in oozie-default.xml and in the code should be the > > same. and 100000 seems a bit too high, shouldn't we cap on 1000 as default?
the default value is kept high to not break the current info api. There are some coord jobs with around 10,000 actions. But, I understand that 100000 is also too high. So, should I make it 10,000? Also will reflect that value in the code - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3738/#review4771 ----------------------------------------------------------- On 2012-02-02 18:46:30, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3738/ > ----------------------------------------------------------- > > (Updated 2012-02-02 18:46:30) > > > Review request for oozie. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-673 > > > This addresses bug oozie-673. > https://issues.apache.org/jira/browse/oozie-673 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1239737 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 1239737 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > 1239737 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737 > trunk/core/src/main/resources/oozie-default.xml 1239737 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 1239737 > > Diff: https://reviews.apache.org/r/3738/diff > > > Testing > ------- > > test for sorting added > tested after running cron example > > > Thanks, > > Virag > >
