----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3738/#review4774 -----------------------------------------------------------
Looks good. A 10000 resultset by default means a large DB result, caching locally in the server (because the JSON structure is built in memory) and then network traffic. Still, I'd argue a more sensible default is 1000. I don't see how this will break the client as it is a just a different number of rows being returned. - Alejandro On 2012-02-02 20:00:50, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3738/ > ----------------------------------------------------------- > > (Updated 2012-02-02 20:00:50) > > > Review request for oozie. > > > Summary > ------- > > https://issues.apache.org/jira/browse/OOZIE-673 > > > This addresses bug oozie-673. > https://issues.apache.org/jira/browse/oozie-673 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java > 1239737 > > trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 1239737 > > trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > 1239737 > trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737 > trunk/core/src/main/resources/oozie-default.xml 1239737 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 1239737 > trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737 > > Diff: https://reviews.apache.org/r/3738/diff > > > Testing > ------- > > test for sorting added > tested after running cron example > > > Thanks, > > Virag > >
