----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3787/#review4911 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java <https://reviews.apache.org/r/3787/#comment10815> Will this condition ever be true as the startTimeStamp is already set by the ActionStartXcommand? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java <https://reviews.apache.org/r/3787/#comment10816> javadoc missing Why is the patch addressing two JIRA's - Virag On 2012-02-08 03:16:55, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3787/ > ----------------------------------------------------------- > > (Updated 2012-02-08 03:16:55) > > > Review request for oozie. > > > Summary > ------- > > In JavaActionExecutor, we update action start after submit hadoop job which > caused action start time is later than hadoop submission time. We should move > startTime update earilier. > > > context.setStartData(launcherId, jobTracker, consoleUrl); > > public void setStartData(String externalId, String trackerUri, String > consoleUrl) { > setExternalId(ParamChecker.notEmpty(externalId, "externalId")); > setTrackerUri(ParamChecker.notEmpty(trackerUri, "trackerUri")); > setConsoleUrl(ParamChecker.notEmpty(consoleUrl, "consoleUrl")); > Date now = new Date(); > setStartTime(now); > setLastCheckTime(now); > setStatus(Status.RUNNING); > } > > > This addresses bugs OOZIE-686 and OOZIE-687. > https://issues.apache.org/jira/browse/OOZIE-686 > https://issues.apache.org/jira/browse/OOZIE-687 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1241749 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1241749 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java > 1241749 > > Diff: https://reviews.apache.org/r/3787/diff > > > Testing > ------- > > > Thanks, > > Mohamed > >
