> On 2012-02-08 18:29:57, Virag Kothari wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java, > > line 303 > > <https://reviews.apache.org/r/3787/diff/2/?file=73000#file73000line303> > > > > javadoc missing
it is missing across all the method within this file. I though to make sure i am consistent with the existing code. we may need to open a Jira to assue all the java docs are existing > On 2012-02-08 18:29:57, Virag Kothari wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java, > > line 340 > > <https://reviews.apache.org/r/3787/diff/2/?file=72998#file72998line340> > > > > Will this condition ever be true as the startTimeStamp is already set > > by the ActionStartXcommand? Just to keep the backward compatibility with the test cases. Otherwise we need to change all the test cases to call SetStartTime() before calling SetStartDate() We may need another Jira to take care of test case cleanup - Mohamed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3787/#review4911 ----------------------------------------------------------- On 2012-02-08 03:16:55, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3787/ > ----------------------------------------------------------- > > (Updated 2012-02-08 03:16:55) > > > Review request for oozie. > > > Summary > ------- > > In JavaActionExecutor, we update action start after submit hadoop job which > caused action start time is later than hadoop submission time. We should move > startTime update earilier. > > > context.setStartData(launcherId, jobTracker, consoleUrl); > > public void setStartData(String externalId, String trackerUri, String > consoleUrl) { > setExternalId(ParamChecker.notEmpty(externalId, "externalId")); > setTrackerUri(ParamChecker.notEmpty(trackerUri, "trackerUri")); > setConsoleUrl(ParamChecker.notEmpty(consoleUrl, "consoleUrl")); > Date now = new Date(); > setStartTime(now); > setLastCheckTime(now); > setStatus(Status.RUNNING); > } > > > This addresses bugs OOZIE-686 and OOZIE-687. > https://issues.apache.org/jira/browse/OOZIE-686 > https://issues.apache.org/jira/browse/OOZIE-687 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1241749 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java > 1241749 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/WorkflowActionBean.java > 1241749 > > Diff: https://reviews.apache.org/r/3787/diff > > > Testing > ------- > > > Thanks, > > Mohamed > >
