----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3827/#review5000 -----------------------------------------------------------
Some more comments to make the error messages cleaner and usage of the LauncherException tighter. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3827/#comment11003> Can we remove the default constructor and force developers to use one of the other two constructors? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java <https://reviews.apache.org/r/3827/#comment10997> Can you add a message here - fail("Expected to catch an exception but did not encounter any") ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java <https://reviews.apache.org/r/3827/#comment10998> Can you add a message here - fail("Expected a LauncherException but received an Exception") ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java <https://reviews.apache.org/r/3827/#comment10999> Can you add a message here - fail("Expected to catch an exception but did not encounter any") ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java <https://reviews.apache.org/r/3827/#comment11000> Can you add a message here - fail("Expected a LauncherException but received an Exception") ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java <https://reviews.apache.org/r/3827/#comment11002> Can you add a message here - fail("Expected to catch an exception but did not encounter any") ? trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java <https://reviews.apache.org/r/3827/#comment11001> Can you add a message here - fail("Expected a LauncherException but received an Exception") ? - Santhosh On 2012-02-10 00:41:55, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3827/ > ----------------------------------------------------------- > > (Updated 2012-02-10 00:41:55) > > > Review request for oozie, Santhosh Srinivasan and Alejandro Abdelnur. > > > Summary > ------- > > This is Kiran's patch. I am uploading the diff as he is not here. Original > diff at https://reviews.apache.org/r/3143/ > Thanks Alejandro for testing the patch out. The testcases are fixed now. > > > This addresses bug oozie-616. > https://issues.apache.org/jira/browse/oozie-616 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1242619 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1242619 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FileSystemActions.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1242619 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1242619 > > Diff: https://reviews.apache.org/r/3827/diff > > > Testing > ------- > > Ran the entire test suite > > > Thanks, > > Virag > >
