----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3827/#review5018 -----------------------------------------------------------
One comment - if you can address/answer it then its good to go. trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java <https://reviews.apache.org/r/3827/#comment11019> configureFailureEx can be thrown directly. Are you wrapping it to retain the context from configure(jobConf) ? - Santhosh On 2012-02-10 03:48:04, Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3827/ > ----------------------------------------------------------- > > (Updated 2012-02-10 03:48:04) > > > Review request for oozie, Santhosh Srinivasan and Alejandro Abdelnur. > > > Summary > ------- > > This is Kiran's patch. I am uploading the diff as he is not here. Original > diff at https://reviews.apache.org/r/3143/ > Thanks Alejandro for testing the patch out. The testcases are fixed now. > > > This addresses bug oozie-616. > https://issues.apache.org/jira/browse/oozie-616 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FileSystemActions.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1242619 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1242619 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFileSystemActions.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1242619 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 1242619 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1242619 > > Diff: https://reviews.apache.org/r/3827/diff > > > Testing > ------- > > Ran the entire test suite > > > Thanks, > > Virag > >
