----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4035/#review5367 -----------------------------------------------------------
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java <https://reviews.apache.org/r/4035/#comment11685> Is it possible to put this line within if(used) ? This is the common execution path for all commands. Any synchronization, will add a overhead on the processing. I know there could be double-locking issue for that. - Mohammad On 2012-02-24 19:44:14, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4035/ > ----------------------------------------------------------- > > (Updated 2012-02-24 19:44:14) > > > Review request for oozie. > > > Summary > ------- > > While executing an interrupt driven commands it may be executed from the map > on one thread and executed from the queue at a different thread > This will cause the following exception to be thrown: > java.lang.IllegalStateException: CoordChangeXCommand already used. > > - Avoiding throwing exception in case of interrupts and synchronizing the > changes in [used] > - Avoiding executing interrupt in case of commands that doesn't need locks > - Changing the debug message for execute interrupt to explicitly mentioning > it is an interrupt command > > > This addresses bug OOZIE-684. > https://issues.apache.org/jira/browse/OOZIE-684 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java > 1293381 > > Diff: https://reviews.apache.org/r/4035/diff > > > Testing > ------- > > > Thanks, > > Mohamed > >
