-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4035/
-----------------------------------------------------------

(Updated 2012-03-02 23:03:35.875277)


Review request for oozie.


Changes
-------

Updated based on reviewers comments 


Summary
-------

While executing an interrupt driven commands it may be executed from the map on 
one thread and executed from the queue at a different thread 
This will cause the following exception to be thrown: 
java.lang.IllegalStateException: CoordChangeXCommand already used. 

- Avoiding throwing exception in case of interrupts and synchronizing the 
changes in [used] 
- Avoiding executing interrupt in case of commands that doesn't need locks
- Changing the debug message for execute interrupt to explicitly mentioning it 
is an interrupt command


This addresses bug OOZIE-684.
    https://issues.apache.org/jira/browse/OOZIE-684


Diffs (updated)
-----

  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/XCallable.java
 1296506 
  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java
 1296506 
  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java
 1296506 
  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java
 1296506 
  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/Command.java
 1296506 
  
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
 1296506 

Diff: https://reviews.apache.org/r/4035/diff


Testing
-------


Thanks,

Mohamed

Reply via email to