[ 
https://issues.apache.org/jira/browse/OOZIE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218414#comment-13218414
 ] 

[email protected] commented on OOZIE-701:
-----------------------------------------------------



bq.  On 2012-02-28 05:43:27, Mohamed Battisha wrote:
bq.  > 
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java, 
line 135
bq.  > <https://reviews.apache.org/r/4080/diff/1/?file=86198#file86198line135>
bq.  >
bq.  >     Do we need to change the command classes?
bq.  >     I am assuming they are already absolute.

until we remove the old commands I'd try to keep them in sync.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4080/#review5385
-----------------------------------------------------------


On 2012-02-28 05:10:52, Alejandro Abdelnur wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4080/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-28 05:10:52)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Moved notification command queuing to signal command, once the transition 
has been computed.
bq.  
bq.  
bq.  This addresses bug OOZIE-701.
bq.      https://issues.apache.org/jira/browse/OOZIE-701
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java 
1294462 
bq.    
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java 
1294462 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/SignalCommand.java 
1294462 
bq.    trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java 
1294462 
bq.    trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1294462 
bq.  
bq.  Diff: https://reviews.apache.org/r/4080/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Modified TestDagEngine to test callback URL for actions
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Alejandro
bq.  
bq.


                
> Oozie notification URLs don't get replaced with the taken transition
> --------------------------------------------------------------------
>
>                 Key: OOZIE-701
>                 URL: https://issues.apache.org/jira/browse/OOZIE-701
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>
> Transition shows a 'T:null'.
> It seems that the issue is that the notification command for action ends is 
> done at action end command, it should be done in signal command as it is 
> there where the transition is computed. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to