[
https://issues.apache.org/jira/browse/OOZIE-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218415#comment-13218415
]
[email protected] commented on OOZIE-701:
-----------------------------------------------------
bq. On 2012-02-28 07:53:29, Mohammad Islam wrote:
bq. > Overall what is the benefit? Does it mean ActionEnnComand is called for
terminal states and all other transitions are failing to send notification?
bq. >
the actionendcommands are called when the action ends but before the
workflowlib resolves the transition, thus transition replacement is always
NULL, thus this fix.
bq. On 2012-02-28 07:53:29, Mohammad Islam wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java, line
190
bq. > <https://reviews.apache.org/r/4080/diff/1/?file=86201#file86201line190>
bq. >
bq. > Shouldn't we queue the NotifcationCommand here too?
bq. > Same for FAILED at 198.
good point, i'll update the patch.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4080/#review5387
-----------------------------------------------------------
On 2012-02-28 05:10:52, Alejandro Abdelnur wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4080/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-28 05:10:52)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Moved notification command queuing to signal command, once the transition
has been computed.
bq.
bq.
bq. This addresses bug OOZIE-701.
bq. https://issues.apache.org/jira/browse/OOZIE-701
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndCommand.java
1294462
bq.
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java
1294462
bq. trunk/core/src/main/java/org/apache/oozie/command/wf/SignalCommand.java
1294462
bq. trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java
1294462
bq. trunk/core/src/test/java/org/apache/oozie/TestDagEngine.java 1294462
bq.
bq. Diff: https://reviews.apache.org/r/4080/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified TestDagEngine to test callback URL for actions
bq.
bq.
bq. Thanks,
bq.
bq. Alejandro
bq.
bq.
> Oozie notification URLs don't get replaced with the taken transition
> --------------------------------------------------------------------
>
> Key: OOZIE-701
> URL: https://issues.apache.org/jira/browse/OOZIE-701
> Project: Oozie
> Issue Type: Bug
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
>
> Transition shows a 'T:null'.
> It seems that the issue is that the notification command for action ends is
> done at action end command, it should be done in signal command as it is
> there where the transition is computed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
