----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4176/#review5625 -----------------------------------------------------------
Ship it! +1 - Mohammad On 2012-03-05 17:51:33, Alejandro Abdelnur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4176/ > ----------------------------------------------------------- > > (Updated 2012-03-05 17:51:33) > > > Review request for oozie. > > > Summary > ------- > > The KerberosHadoopAccessorService subclass was implemented as a separate > implementation to provide support for pre-UGI and UGI versions of Hadoop at > the same time. The DoAs/KerberosDoAs classes were there to make testcases run > with pre-UGI and UGI versions of Hadoop at the same time. > > As the versions of Hadoop supported by trunk (3.2.0) all have UGI, we don't > need these classes anymore. > > The KerberosHadoopAccessorService logic can be folded into the > HadoopAccessorService & the doAs classes can be removed. > > > This addresses bug OOZIE-734. > https://issues.apache.org/jira/browse/OOZIE-734 > > > Diffs > ----- > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/AuthHelper.java > 1297142 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/DoAs.java 1297142 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1297142 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/KerberosAuthHelper.java > 1297142 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/KerberosDoAs.java > 1297142 > > trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 1297142 > > trunk/core/src/main/java/org/apache/oozie/service/KerberosHadoopAccessorService.java > 1297142 > trunk/core/src/main/resources/oozie-default.xml 1297142 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/MainTestCase.java > 1297142 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java > 1297142 > trunk/core/src/test/java/org/apache/oozie/action/hadoop/ShellTestCase.java > 1297142 > > trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > 1297142 > > trunk/core/src/test/java/org/apache/oozie/service/TestKerberosHadoopAccessorService.java > 1297142 > trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1297142 > trunk/docs/src/site/twiki/AG_Install.twiki 1297142 > trunk/docs/src/site/twiki/ENG_Building.twiki 1297142 > > trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java > 1297142 > > Diff: https://reviews.apache.org/r/4176/diff > > > Testing > ------- > > Run all testcases successfully > > > Thanks, > > Alejandro > >
