[
https://issues.apache.org/jira/browse/OOZIE-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223948#comment-13223948
]
[email protected] commented on OOZIE-684:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4035/
-----------------------------------------------------------
(Updated 2012-03-07 03:51:47.441182)
Review request for oozie.
Changes
-------
Updated based on the reviewer comments
Summary
-------
While executing an interrupt driven commands it may be executed from the map on
one thread and executed from the queue at a different thread
This will cause the following exception to be thrown:
java.lang.IllegalStateException: CoordChangeXCommand already used.
- Avoiding throwing exception in case of interrupts and synchronizing the
changes in [used]
- Avoiding executing interrupt in case of commands that doesn't need locks
- Changing the debug message for execute interrupt to explicitly mentioning it
is an interrupt command
This addresses bug OOZIE-684.
https://issues.apache.org/jira/browse/OOZIE-684
Diffs (updated)
-----
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/Command.java
1296506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/command/XCommand.java
1296506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/CallableQueueService.java
1296506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/util/XCallable.java
1296506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/command/TestCommand.java
1296506
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java
1296506
Diff: https://reviews.apache.org/r/4035/diff
Testing
-------
Thanks,
Mohamed
> A race condition may happen under stress while executing an interrupt command
> -----------------------------------------------------------------------------
>
> Key: OOZIE-684
> URL: https://issues.apache.org/jira/browse/OOZIE-684
> Project: Oozie
> Issue Type: Bug
> Reporter: Mohamed Battisha
> Labels: performance
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> While executing an interrupt driven commands it may be executed from the map
> on one thread and executed from the queue at a different thread
> This will cause the following exception to be thrown:
> java.lang.IllegalStateException: CoordChangeXCommand already used.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
