[
https://issues.apache.org/jira/browse/OOZIE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225157#comment-13225157
]
[email protected] commented on OOZIE-675:
-----------------------------------------------------
bq. On 2012-03-08 09:01:30, Mohammad Islam wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java, line 221
bq. > <https://reviews.apache.org/r/4222/diff/1/?file=88747#file88747line221>
bq. >
bq. > how to identify this ${func(), func2()}?
bq. > that means in one ${ } there are multiple functions.
I guess this wont be a valid el expression. I am assuming ExpressionEvaluator
would reject it. Will check and confirm.
bq. On 2012-03-08 09:01:30, Mohammad Islam wrote:
bq. > trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java, line 229
bq. > <https://reviews.apache.org/r/4222/diff/1/?file=88747#file88747line229>
bq. >
bq. > is it possible to add one/two unit test case for this new method in
TestELEvaluator.jav? Both cases +ve and -ve.
bq. > This is a critical pieces, hence asking to be more cautious.
Sure. Will put up an updated patch
bq. On 2012-03-08 09:01:30, Mohammad Islam wrote:
bq. >
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java,
line 323
bq. > <https://reviews.apache.org/r/4222/diff/1/?file=88746#file88746line323>
bq. >
bq. > Line 323-330 and line 333-340 look similar.
bq. > is it possible to create a method and invoke it from the same place.
Yes. Makes sense. Will put up a revised patch shortly
- Srikanth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4222/#review5707
-----------------------------------------------------------
On 2012-03-08 08:19:24, Srikanth Sundarrajan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4222/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 08:19:24)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. checkMultipleTimeInstances doesn't work for EL extensions. EX:
${coord:formatTime(coord:current(0),'yyyy-MM-dd')}
bq.
bq.
bq. This addresses bug OOZIE-675.
bq. https://issues.apache.org/jira/browse/OOZIE-675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1297367
bq. trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1297367
bq. trunk/core/src/test/resources/coord-multiple-output-instance4.xml
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4222/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New test case added to TestCoordSubmitXCommand.java for verifying the
changes
bq.
bq.
bq. Thanks,
bq.
bq. Srikanth
bq.
bq.
> checkMultipleTimeInstances doesn't work for EL extensions
> ---------------------------------------------------------
>
> Key: OOZIE-675
> URL: https://issues.apache.org/jira/browse/OOZIE-675
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Shwetha G S
> Labels: EL, extensions
>
> To guard against specifying multiple instances in instance tag,
> CoordSubmitXCommand.checkMultipleTimeInstances checks for ',' in instance
> tag. This breaks for EL extensions. We have EL extension today(0,0) which
> maps to start day of nominal time. today(0,0) resolves to a single instance
> and presence of ',' doesn't imply that it resolves to multiple instances
> Can you please fix this
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
