[
https://issues.apache.org/jira/browse/OOZIE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13226008#comment-13226008
]
[email protected] commented on OOZIE-675:
-----------------------------------------------------
bq. On 2012-03-08 20:34:17, Mona Chitnis wrote:
bq. > There is another type of EL expression of the format e.g.
${coord:future(start_instance,max_instance)} that needs to be tested. This type
carries a "comma" within the function.
bq.
bq. Alejandro Abdelnur wrote:
bq. Srikanth, looks good. Would be possible to have a negative test as
well?
I have modified input for testBasicSubmitWithMultipleInstancesOutputEvent, to
include tests for future() function as well.
testBasicSubmitWithMultipleInstancesInputEvent::case 1 &
testBasicSubmitWithMultipleInstancesOutputEvent:case 1 are actually a negative
case where "," is present outside a function, which are gated appropriately.
testBasicSubmitWithMultipleInstancesOutputEvent::Case 4 checks for both input
and output with "," within the context of a function.
- Srikanth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4222/#review5747
-----------------------------------------------------------
On 2012-03-08 15:08:40, Srikanth Sundarrajan wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4222/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 15:08:40)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. checkMultipleTimeInstances doesn't work for EL extensions. EX:
${coord:formatTime(coord:current(0),'yyyy-MM-dd')}
bq.
bq.
bq. This addresses bug OOZIE-675.
bq. https://issues.apache.org/jira/browse/OOZIE-675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java
1297367
bq. trunk/core/src/main/java/org/apache/oozie/util/ELEvaluator.java 1297367
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java
1297367
bq. trunk/core/src/test/java/org/apache/oozie/util/TestELEvaluator.java
1297367
bq. trunk/core/src/test/resources/coord-multiple-output-instance4.xml
PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4222/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. * New test case added to TestCoordSubmitXCommand.java for verifying the
changes
bq. * Added additional test cases to TestELEvaluator.java as well
bq.
bq.
bq. Thanks,
bq.
bq. Srikanth
bq.
bq.
> checkMultipleTimeInstances doesn't work for EL extensions
> ---------------------------------------------------------
>
> Key: OOZIE-675
> URL: https://issues.apache.org/jira/browse/OOZIE-675
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 3.2.0
> Reporter: Shwetha G S
> Labels: EL, extensions
>
> To guard against specifying multiple instances in instance tag,
> CoordSubmitXCommand.checkMultipleTimeInstances checks for ',' in instance
> tag. This breaks for EL extensions. We have EL extension today(0,0) which
> maps to start day of nominal time. today(0,0) resolves to a single instance
> and presence of ',' doesn't imply that it resolves to multiple instances
> Can you please fix this
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
