[ 
https://issues.apache.org/jira/browse/OOZIE-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13229909#comment-13229909
 ] 

[email protected] commented on OOZIE-674:
-----------------------------------------------------



bq.  On 2012-03-12 17:24:08, Alejandro Abdelnur wrote:
bq.  > Any reason for these new functions to be in an coordext: namespace as 
opposed to the coord: namespace?

It can be in any namespace. The reason I used a different namespace is to 
signify that its an extension and not in-built oozie EL function.


- shwethags


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3752/#review5838
-----------------------------------------------------------


On 2012-03-07 09:43:36, shwethags wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3752/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-07 09:43:36)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  I have an EL extension today(0,0) which maps to start day of nominal time. 
This is used to specify startInstance, endInstance and instance in dataIn and 
dataOut of coordinator.
bq.  
bq.  In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to 
return the instance number with respect to current. So, for 
coord-action-create-inst context, I have mapped today to current and hence 
getInstanceNumber returns the correct number. But later in 
resolveInstanceRange(), getFuncType is called with startInstance value which is 
today in this case and it maps to UNEXPECTED and throws up. getFuncType should 
be passed the evaluation of coord-action-create-inst context
bq.  
bq.  
bq.  This addresses bug OOZIE-674.
bq.      https://issues.apache.org/jira/browse/OOZIE-674
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 
1297889 
bq.    trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 
1297889 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/CoordELExtension.java 
PRE-CREATION 
bq.    
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordELExtensions.java
 PRE-CREATION 
bq.    trunk/core/src/test/resources/oozie-site-coordel.xml PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/3752/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  UT - TestCoordActionMaterializeCommand
bq.  Tested with coord:current instance range and EL extension
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  shwethags
bq.  
bq.


                
> resolveInstanceRange doesn't work for EL extensions
> ---------------------------------------------------
>
>                 Key: OOZIE-674
>                 URL: https://issues.apache.org/jira/browse/OOZIE-674
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Shwetha G S
>              Labels: EL, extension
>         Attachments: OOZIE-674.patch
>
>
> I have an EL extension today(0,0) which maps to start day of nominal time. 
> This is used to specify startInstance, endInstance and instance in dataIn and 
> dataOut of coordinator.
> In CoordCommandUtils.resolveInstanceRange(), getInstanceNumber has to return 
> the instance number with respect to current. So, for coord-action-create-inst 
> context, I have mapped today to current and hence getInstanceNumber returns 
> the correct number. But later in resolveInstanceRange(), getFuncType is 
> called with startInstance value which is today in this case and it maps to 
> UNEXPECTED and throws up. getFuncType should be passed the evaluation of 
> coord-action-create-inst context

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to