-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4432/#review6173
-----------------------------------------------------------


Sam`

After the following tweaks your patch works as advertised:


Index: core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java

+        String expr = "${coord:conf('my.test.variable')}";

Index: core/src/test/resources/coord-action-get.xml

+      <app-path>${coord:conf('wfAppPath')}</app-path>

Would you upload a patch with these tweaks?

Thanks.

Alejandro

- Alejandro


On 2012-03-21 17:54:52, Maxime Petazzoni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4432/
> -----------------------------------------------------------
> 
> (Updated 2012-03-21 17:54:52)
> 
> 
> Review request for oozie.
> 
> 
> Summary
> -------
> 
> Work in progress implementation of the coord:conf EL function in Oozie 
> coordinators.
> 
> 
> This addresses bug OOZIE-774.
>     https://issues.apache.org/jira/browse/OOZIE-774
> 
> 
> Diffs
> -----
> 
>   /trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 
> 1302703 
>   /trunk/core/src/main/resources/oozie-default.xml 1302703 
>   /trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 
> 1302703 
>   /trunk/core/src/test/resources/coord-action-get.xml 1302703 
> 
> Diff: https://reviews.apache.org/r/4432/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxime
> 
>

Reply via email to