> On 2012-03-21 18:03:07, Alejandro Abdelnur wrote:
> > Sam`
> >
> > After the following tweaks your patch works as advertised:
> >
> >
> > Index: core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java
> >
> > + String expr = "${coord:conf('my.test.variable')}";
> >
> > Index: core/src/test/resources/coord-action-get.xml
> >
> > + <app-path>${coord:conf('wfAppPath')}</app-path>
> >
> > Would you upload a patch with these tweaks?
> >
> > Thanks.
> >
> > Alejandro
>
> Maxime Petazzoni wrote:
> That's indeed a typo in the test (missing bracket). I was not able to run
> the tests unfortunately as you know so I couldn't pick this one up.
>
> But if I understand correctly, I need to use quotes around the variable
> name to get it working? Why is that not the case for wf:conf()?
>
> Thanks,
> /Max
in wf:coord() you also need to use quotes, see TestDagELFunctions line 83
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4432/#review6173
-----------------------------------------------------------
On 2012-03-21 21:29:43, Maxime Petazzoni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4432/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 21:29:43)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Work in progress implementation of the coord:conf EL function in Oozie
> coordinators.
>
>
> This addresses bug OOZIE-774.
> https://issues.apache.org/jira/browse/OOZIE-774
>
>
> Diffs
> -----
>
> /trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
> 1302703
> /trunk/core/src/main/resources/oozie-default.xml 1302703
> /trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java
> 1302703
> /trunk/core/src/test/resources/coord-action-get.xml 1302703
>
> Diff: https://reviews.apache.org/r/4432/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxime
>
>
