[ 
https://issues.apache.org/jira/browse/OOZIE-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234613#comment-13234613
 ] 

[email protected] commented on OOZIE-774:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4432/#review6173
-----------------------------------------------------------


Sam`

After the following tweaks your patch works as advertised:


Index: core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java

+        String expr = "${coord:conf('my.test.variable')}";

Index: core/src/test/resources/coord-action-get.xml

+      <app-path>${coord:conf('wfAppPath')}</app-path>

Would you upload a patch with these tweaks?

Thanks.

Alejandro

- Alejandro


On 2012-03-21 17:54:52, Maxime Petazzoni wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/4432/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-03-21 17:54:52)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Work in progress implementation of the coord:conf EL function in Oozie 
coordinators.
bq.  
bq.  
bq.  This addresses bug OOZIE-774.
bq.      https://issues.apache.org/jira/browse/OOZIE-774
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    /trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 
1302703 
bq.    /trunk/core/src/main/resources/oozie-default.xml 1302703 
bq.    
/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java 
1302703 
bq.    /trunk/core/src/test/resources/coord-action-get.xml 1302703 
bq.  
bq.  Diff: https://reviews.apache.org/r/4432/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Maxime
bq.  
bq.


                
> Support coord:conf to access configuration properties from coordinators
> -----------------------------------------------------------------------
>
>                 Key: OOZIE-774
>                 URL: https://issues.apache.org/jira/browse/OOZIE-774
>             Project: Oozie
>          Issue Type: Improvement
>          Components: core
>            Reporter: Maxime Petazzoni
>            Priority: Minor
>
> It would be nice to be able to access configuration properties from a 
> coordinator's XML file with a coord:conf() function similar to wf:conf() in 
> workflow XML files so that we can access job properties with any name (not 
> just valid Java identifiers).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to