[
https://issues.apache.org/jira/browse/OOZIE-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235073#comment-13235073
]
[email protected] commented on OOZIE-774:
-----------------------------------------------------
bq. On 2012-03-21 18:03:07, Alejandro Abdelnur wrote:
bq. > Sam`
bq. >
bq. > After the following tweaks your patch works as advertised:
bq. >
bq. >
bq. > Index:
core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java
bq. >
bq. > + String expr = "${coord:conf('my.test.variable')}";
bq. >
bq. > Index: core/src/test/resources/coord-action-get.xml
bq. >
bq. > + <app-path>${coord:conf('wfAppPath')}</app-path>
bq. >
bq. > Would you upload a patch with these tweaks?
bq. >
bq. > Thanks.
bq. >
bq. > Alejandro
bq.
bq. Maxime Petazzoni wrote:
bq. That's indeed a typo in the test (missing bracket). I was not able to
run the tests unfortunately as you know so I couldn't pick this one up.
bq.
bq. But if I understand correctly, I need to use quotes around the
variable name to get it working? Why is that not the case for wf:conf()?
bq.
bq. Thanks,
bq. /Max
bq.
bq. Alejandro Abdelnur wrote:
bq. in wf:coord() you also need to use quotes, see TestDagELFunctions line
83
bq.
bq.
bq. Maxime Petazzoni wrote:
bq. I'm seeing this indeed. In my experience it worked without though, and
since the documentation didn't have any examples to show a "best practice", I
didn't think much of it. But having the quotes is good practice indeed,
especially if "The Way That Works(TM)".
bq.
bq. Thanks
Mhh, it may work for properties without DOTs
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4432/#review6173
-----------------------------------------------------------
On 2012-03-21 21:29:43, Maxime Petazzoni wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4432/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 21:29:43)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Work in progress implementation of the coord:conf EL function in Oozie
coordinators.
bq.
bq.
bq. This addresses bug OOZIE-774.
bq. https://issues.apache.org/jira/browse/OOZIE-774
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java
1302703
bq. /trunk/core/src/main/resources/oozie-default.xml 1302703
bq.
/trunk/core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java
1302703
bq. /trunk/core/src/test/resources/coord-action-get.xml 1302703
bq.
bq. Diff: https://reviews.apache.org/r/4432/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Maxime
bq.
bq.
> Support coord:conf to access configuration properties from coordinators
> -----------------------------------------------------------------------
>
> Key: OOZIE-774
> URL: https://issues.apache.org/jira/browse/OOZIE-774
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Reporter: Maxime Petazzoni
> Priority: Minor
>
> It would be nice to be able to access configuration properties from a
> coordinator's XML file with a coord:conf() function similar to wf:conf() in
> workflow XML files so that we can access job properties with any name (not
> just valid Java identifiers).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
