[
https://issues.apache.org/jira/browse/OOZIE-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238825#comment-13238825
] [email protected] commented on OOZIE-741: ----------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4476/#review6366 ----------------------------------------------------------- A few comments. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java <https://reviews.apache.org/r/4476/#comment13817> length. Should we use size instead of length? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/4476/#comment13818> Is this required since the method throws WorkflowException? Move the catch to the previous line as per Java coding standard if you are retaining the catch block. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/4476/#comment13825> Is this big enough to cover most of the existing users? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/4476/#comment13824> What is the unit - bytes? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/4476/#comment13819> exceeds http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java <https://reviews.apache.org/r/4476/#comment13820> exceeds http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java <https://reviews.apache.org/r/4476/#comment13823> Can you include a message for the failure? http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java <https://reviews.apache.org/r/4476/#comment13821> Move the catch to the previous line as per Java coding convention http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java <https://reviews.apache.org/r/4476/#comment13822> Move finally to the previous line - Santhosh On 2012-03-26 04:34:14, Mohamed Battisha wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4476/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-03-26 04:34:14) bq. bq. bq. Review request for oozie. bq. bq. bq. Summary bq. ------- bq. bq. Currently there is no limit to the xml file that is submitted by the user. submitting a big file make cause some issues bq. bq. bq. This addresses bug oozie-741. bq. https://issues.apache.org/jira/browse/oozie-741 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1304533 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1304533 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml 1304533 bq. http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java 1304533 bq. bq. Diff: https://reviews.apache.org/r/4476/diff bq. bq. bq. Testing bq. ------- bq. bq. New test cases are added bq. bq. bq. Thanks, bq. bq. Mohamed bq. bq. > Restrict the size of submitted workflow xml file > -------------------------------------------------- > > Key: OOZIE-741 > URL: https://issues.apache.org/jira/browse/OOZIE-741 > Project: Oozie > Issue Type: Improvement > Components: workflow > Affects Versions: 3.2.0 > Reporter: Mohamed Battisha > Priority: Minor > Fix For: 3.2.0 > > Original Estimate: 5h > Remaining Estimate: 5h > > Currently there is no limit to the xml file that is submitted by the user. > submitting a big file make cause some issues > We need to catch this as early as possible. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
