[
https://issues.apache.org/jira/browse/OOZIE-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13244851#comment-13244851
]
[email protected] commented on OOZIE-741:
-----------------------------------------------------
bq. On 2012-03-26 21:01:19, Santhosh Srinivasan wrote:
bq. >
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java,
line 128
bq. > <https://reviews.apache.org/r/4476/diff/2/?file=95543#file95543line128>
bq. >
bq. > Is this required since the method throws WorkflowException?
bq. >
bq. > Move the catch to the previous line as per Java coding standard if
you are retaining the catch block.
bq.
bq. Mohamed Battisha wrote:
bq. it is required as we need to differentiate beween a generic exception
which has be caught later and WorkflowException which we are handling here.
bq.
bq.
I think its better to remove the generic exception. In that case, no need for
catch as throws is already present.
- Virag
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4476/#review6366
-----------------------------------------------------------
On 2012-03-29 23:49:15, Mohamed Battisha wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4476/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-29 23:49:15)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently there is no limit to the xml file that is submitted by the user.
submitting a big file make cause some issues
bq.
bq.
bq. This addresses bug oozie-741.
bq. https://issues.apache.org/jira/browse/oozie-741
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java
1307166
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java
1307166
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
1307166
bq.
http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java
1307166
bq.
bq. Diff: https://reviews.apache.org/r/4476/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. New test cases are added
bq.
bq.
bq. Thanks,
bq.
bq. Mohamed
bq.
bq.
> Restrict the size of submitted workflow xml file
> --------------------------------------------------
>
> Key: OOZIE-741
> URL: https://issues.apache.org/jira/browse/OOZIE-741
> Project: Oozie
> Issue Type: Improvement
> Components: workflow
> Affects Versions: 3.2.0
> Reporter: Mohamed Battisha
> Priority: Minor
> Fix For: 3.2.0
>
> Original Estimate: 5h
> Remaining Estimate: 5h
>
> Currently there is no limit to the xml file that is submitted by the user.
> submitting a big file make cause some issues
> We need to catch this as early as possible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
