[
https://issues.apache.org/jira/browse/OOZIE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240663#comment-13240663
]
[email protected] commented on OOZIE-780:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4472/#review6486
-----------------------------------------------------------
Ship it!
it looks good.
the only thing I'd ask to be done with the testcase is the following:
Instead loading the conf file as a resource from the classloader and having the
included file as 'src/main/test/resources/...', both files should be copied to
the testcase directory (obtained via XTestCase.getTestDir() ) and the include
should be relative with no subdirs. then the stream of the main conf should be
read from there.
the reason for this is that while maven runs the testcases from trunk/core/,
IDEs run it from trunk/ (or the current dir) and the testcase will fail from
within the IDE
- Alejandro
On 2012-03-23 23:41:10, Virag Kothari wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4472/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 23:41:10)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Adding support for Xinclude in xml which is similar to what Hadoop has
bq.
bq.
bq. This addresses bug oozie-780.
bq. https://issues.apache.org/jira/browse/oozie-780
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/util/XConfiguration.java
1304647
bq. trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java
1304647
bq. trunk/core/src/test/resources/test-hadoop-config.xml 1304647
bq. trunk/core/src/test/resources/test-oozie-default.xml 1304647
bq.
bq. Diff: https://reviews.apache.org/r/4472/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Virag
bq.
bq.
> XConfiguration parser can't parse XML file with <include> element
> -----------------------------------------------------------------
>
> Key: OOZIE-780
> URL: https://issues.apache.org/jira/browse/OOZIE-780
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> E.g core-site.xml
> <xi:include href="**/local-superuser-conf.xml"/>
> <property>
> </property>
> If the hadoop configs like core-site.xml has an <include> element along with
> <property> elements, then Xconfiguration cannot parse it and
> HadoopAccessorService cannot load it.
> This piece of code in Xconfiguration throws the error:
> if (!"property".equals(prop.getTagName())) {
> throw new IOException("bad conf file: element not
> <property>");
> }
> This jira proposes to provide functionality to combine xmls by supporting the
> <include> element
> StackTrace:
> Caused by: java.io.IOException: bad conf file: element not <property>
> at
> org.apache.oozie.util.XConfiguration.parseDocument(XConfiguration.java:287)
> at org.apache.oozie.util.XConfiguration.parse(XConfiguration.java:244)
> at org.apache.oozie.util.XConfiguration.<init>(XConfiguration.java:63)
> at
> org.apache.oozie.service.HadoopAccessorService.loadHadoopConf(HadoopAccessorService.java:152)
> at
> org.apache.oozie.service.HadoopAccessorService.loadHadoopConfigs(HadoopAccessorService.java:175)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
