[
https://issues.apache.org/jira/browse/OOZIE-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240886#comment-13240886
]
[email protected] commented on OOZIE-780:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4472/
-----------------------------------------------------------
(Updated 2012-03-29 01:32:03.496689)
Review request for oozie.
Changes
-------
Xinclude doesn't handle relative paths properly. Discussed with Alejandro and
added absolute path for xinclude in testcases.
Summary
-------
Adding support for Xinclude in xml which is similar to what Hadoop has
This addresses bug oozie-780.
https://issues.apache.org/jira/browse/oozie-780
Diffs (updated)
-----
trunk/core/src/main/java/org/apache/oozie/util/XConfiguration.java 1305659
trunk/core/src/test/resources/test-hadoop-config.xml 1305659
trunk/core/src/test/resources/test-oozie-default.xml 1305659
trunk/core/src/test/java/org/apache/oozie/util/TestXConfiguration.java
1305659
Diff: https://reviews.apache.org/r/4472/diff
Testing
-------
Thanks,
Virag
> XConfiguration parser can't parse XML file with <include> element
> -----------------------------------------------------------------
>
> Key: OOZIE-780
> URL: https://issues.apache.org/jira/browse/OOZIE-780
> Project: Oozie
> Issue Type: Bug
> Reporter: Virag Kothari
>
> E.g core-site.xml
> <xi:include href="**/local-superuser-conf.xml"/>
> <property>
> </property>
> If the hadoop configs like core-site.xml has an <include> element along with
> <property> elements, then Xconfiguration cannot parse it and
> HadoopAccessorService cannot load it.
> This piece of code in Xconfiguration throws the error:
> if (!"property".equals(prop.getTagName())) {
> throw new IOException("bad conf file: element not
> <property>");
> }
> This jira proposes to provide functionality to combine xmls by supporting the
> <include> element
> StackTrace:
> Caused by: java.io.IOException: bad conf file: element not <property>
> at
> org.apache.oozie.util.XConfiguration.parseDocument(XConfiguration.java:287)
> at org.apache.oozie.util.XConfiguration.parse(XConfiguration.java:244)
> at org.apache.oozie.util.XConfiguration.<init>(XConfiguration.java:63)
> at
> org.apache.oozie.service.HadoopAccessorService.loadHadoopConf(HadoopAccessorService.java:152)
> at
> org.apache.oozie.service.HadoopAccessorService.loadHadoopConfigs(HadoopAccessorService.java:175)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
