> On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java, > > line 143 > > <https://reviews.apache.org/r/4476/diff/2/?file=95542#file95542line143> > > > > length. Should we use size instead of length?
I believe size is more appropriate but, the length has been used throughout Hadoop code, so I thought to be consistent > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml, > > line 471 > > <https://reviews.apache.org/r/4476/diff/2/?file=95544#file95544line471> > > > > Is this big enough to cover most of the existing users? This has been agreed upon as big enough? As well, it can be changed through oozie-site.xml if needed > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml, > > line 473 > > <https://reviews.apache.org/r/4476/diff/2/?file=95544#file95544line473> > > > > What is the unit - bytes? Yep, will add it to the comment > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java, > > line 119 > > <https://reviews.apache.org/r/4476/diff/2/?file=95545#file95545line119> > > > > Can you include a message for the failure? done > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, > > line 128 > > <https://reviews.apache.org/r/4476/diff/2/?file=95543#file95543line128> > > > > Is this required since the method throws WorkflowException? > > > > Move the catch to the previous line as per Java coding standard if you > > are retaining the catch block. it is required as we need to differentiate beween a generic exception which has be caught later and WorkflowException which we are handling here. > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java, > > line 121 > > <https://reviews.apache.org/r/4476/diff/2/?file=95545#file95545line121> > > > > Move the catch to the previous line as per Java coding convention I am using the oozie formatter. The catch should at a new line. the same style is used throughout the code > On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java, > > line 124 > > <https://reviews.apache.org/r/4476/diff/2/?file=95545#file95545line124> > > > > Move finally to the previous line I am using the oozie formatter. The catch should at a new line. the same style is used throughout the code - Mohamed ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4476/#review6366 ----------------------------------------------------------- On 2012-03-26 04:34:14, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4476/ > ----------------------------------------------------------- > > (Updated 2012-03-26 04:34:14) > > > Review request for oozie. > > > Summary > ------- > > Currently there is no limit to the xml file that is submitted by the user. > submitting a big file make cause some issues > > > This addresses bug oozie-741. > https://issues.apache.org/jira/browse/oozie-741 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java > 1304533 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1304533 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml > 1304533 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1304533 > > Diff: https://reviews.apache.org/r/4476/diff > > > Testing > ------- > > New test cases are added > > > Thanks, > > Mohamed > >
