> On 2012-03-26 21:01:19, Santhosh Srinivasan wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, > > line 128 > > <https://reviews.apache.org/r/4476/diff/2/?file=95543#file95543line128> > > > > Is this required since the method throws WorkflowException? > > > > Move the catch to the previous line as per Java coding standard if you > > are retaining the catch block. > > Mohamed Battisha wrote: > it is required as we need to differentiate beween a generic exception > which has be caught later and WorkflowException which we are handling here. > >
I think its better to remove the generic exception. In that case, no need for catch as throws is already present. - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4476/#review6366 ----------------------------------------------------------- On 2012-03-29 23:49:15, Mohamed Battisha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4476/ > ----------------------------------------------------------- > > (Updated 2012-03-29 23:49:15) > > > Review request for oozie. > > > Summary > ------- > > Currently there is no limit to the xml file that is submitted by the user. > submitting a big file make cause some issues > > > This addresses bug oozie-741. > https://issues.apache.org/jira/browse/oozie-741 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/ErrorCode.java > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml > 1307166 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1307166 > > Diff: https://reviews.apache.org/r/4476/diff > > > Testing > ------- > > New test cases are added > > > Thanks, > > Mohamed > >
