> On 2012-04-23 17:46:35, Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml, > > line 94 > > <https://reviews.apache.org/r/4835/diff/1/?file=103688#file103688line94> > > > > whitespace
have fixed it > On 2012-04-23 17:46:35, Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java, > > line 288 > > <https://reviews.apache.org/r/4835/diff/1/?file=103687#file103687line288> > > > > remove extra whitespaces. have fixed it > On 2012-04-23 17:46:35, Mona Chitnis wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd, > > line 187 > > <https://reviews.apache.org/r/4835/diff/1/?file=103683#file103683line187> > > > > Is occurrence of each operation limited to once? I am afraid there is no need. A choice element means that one and only one of elements in it must appear. If there is another element, it should be treated as another choice element. - Han ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4835/#review7145 ----------------------------------------------------------- On 2012-04-21 04:26:17, Han Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4835/ > ----------------------------------------------------------- > > (Updated 2012-04-21 04:26:17) > > > Review request for oozie. > > > Summary > ------- > > Schema of fs action require the fs operations must follow the sequence of > "delete, mkdir, move, chmod". > The limitation is not reasonable, oozie should allow fs operations to be done > in any sequence users like to. > > > This addresses bug OOZIE-817. > https://issues.apache.org/jira/browse/OOZIE-817 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml > 1327027 > > Diff: https://reviews.apache.org/r/4835/diff > > > Testing > ------- > > * Revise the TestLiteWorkflowAppService to add testing for fs action's schema. > * All testcase are passed. > > > Thanks, > > Han > >
