> On 2012-04-23 18:17:36, Alejandro Abdelnur wrote: > > i don't think the patch will work as expected as the following won't work: > > > > mkdir > > delete > > mkdir > > delete > > > > AFAIK, XML schemas have the limitation that random order is not possible.
At first, i have the same idea with you. However, after read the xml reference, I find using choice element could be a good method. The sequence of "mkdir, delete, mkdir, delete" aslo works, and please just consider any of them is a choice element, an a choice element can be any in "delete, mkdir, move and chmod". Thank you. - Han ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4835/#review7147 ----------------------------------------------------------- On 2012-04-24 03:25:26, Han Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4835/ > ----------------------------------------------------------- > > (Updated 2012-04-24 03:25:26) > > > Review request for oozie. > > > Summary > ------- > > Schema of fs action require the fs operations must follow the sequence of > "delete, mkdir, move, chmod". > The limitation is not reasonable, oozie should allow fs operations to be done > in any sequence users like to. > > > This addresses bug OOZIE-817. > https://issues.apache.org/jira/browse/OOZIE-817 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.1.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.5.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.2.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/client/src/main/resources/oozie-workflow-0.3.xsd > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/test/resources/wf-schema-valid.xml > 1327027 > > Diff: https://reviews.apache.org/r/4835/diff > > > Testing > ------- > > * Revise the TestLiteWorkflowAppService to add testing for fs action's schema. > * All testcase are passed. > > > Thanks, > > Han > >
