> On 2012-04-27 21:55:11, Alejandro Abdelnur wrote: > > The OozieDBCLI tool may require some changes to ensure the DB is > > created/upgraded on the right schema.
Yes, i haven't noticed it before and the patch is updated now. To avoid hardcoding, i revised much of the OozieDBCLI using the jpa. > On 2012-04-27 21:55:11, Alejandro Abdelnur wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java, > > line 58 > > <https://reviews.apache.org/r/4755/diff/1/?file=102363#file102363line58> > > > > the patch has a few trailing spaces/tabs fixed it > On 2012-04-27 21:55:11, Alejandro Abdelnur wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java, > > line 107 > > <https://reviews.apache.org/r/4755/diff/1/?file=102363#file102363line107> > > > > oozie.db.schema.name renaming to oozie.db.name is missed in the default > > value. > > > > Furthermore, there are a few *-site.xml files in oozie test/resources > > dirs (core & examples) that may be using oozie.db.schema.name. > > > > To make it easier, why not leave oozie.db.schema.name untouch? Thanks for your reminding, fixed all of that. Actually, the else revsions only happened to docs. > On 2012-04-27 21:55:11, Alejandro Abdelnur wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java, > > line 162 > > <https://reviews.apache.org/r/4755/diff/1/?file=102363#file102363line162> > > > > why not just using 'dbSchema.length() >0' ? Accept you suggestion. Thanks. > On 2012-04-27 21:55:11, Alejandro Abdelnur wrote: > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml, > > line 1008 > > <https://reviews.apache.org/r/4755/diff/1/?file=102364#file102364line1008> > > > > why keeping both oozie.db.name and oozie.db.schema.name? "oozie.db.name" is the database name. "oozie.db.schema.name" notes the schema of a database, means that a database may contain more schemas. database name is part of the jdbc url. schema is used when access a table in a database, usually like "select * from {schema.name}.{table.name}". So they can't use one variable to denote. - Han ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4755/#review7328 ----------------------------------------------------------- On 2012-04-17 10:39:44, Han Xiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4755/ > ----------------------------------------------------------- > > (Updated 2012-04-17 10:39:44) > > > Review request for oozie. > > > Summary > ------- > > Oozie's JPA service doesn't support configure different schemas for oozie's > db. > Our company wants to use one db for multi oozie clusters, and then we want > each oozie cluster can use different schema of the db. Therefore JPAService > in oozie should support to configure the schema of the db, not just the > database. > The oozie.db.schema.name is use to configure oozie's db name, however, it is > a little confusing for it is not used to configure the actually schema of db. > > > This addresses bug OOZIE-814. > https://issues.apache.org/jira/browse/OOZIE-814 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java > 1327027 > > http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml > 1327027 > > Diff: https://reviews.apache.org/r/4755/diff > > > Testing > ------- > > * Deployed Oozie, added oozie.db.schema.name configs values, succeed to run > the examples on Derby and Postgres databases. > > > Thanks, > > Han > >
