> On 2012-05-11 17:50:16, Alejandro Abdelnur wrote:
> > I've run 'ooziedb.sh create -sqlfile x.sql' with the patch and i've noticed
> > that the table indexes are not being created anymore and that the
> > OOZIE_SYS table is not seeded with data:
> >
> >
> > create table OOZIE_SYS (name varchar(100), data varchar(100))
> > insert into OOZIE_SYS (name, data) values ('db.version', '1')
> > insert into OOZIE_SYS (name, data) values ('oozie.version',
> > '3.2.0-SNAPSHOT')
> >
>
> Han Xiao wrote:
> The index is no need, the 'name' filed is assigned as primary key, so
> database will create index for it when create the OOZIE_SYS table;
> You can see wf_actions in which id is the priamry key and there is no
> index for it also.
> The data is insert in the createOozieSysTable() method. I use jpa to
> insert the data, so there is no explict sql for it.
> I find no way to get the sql directly from jpa's persist() method, which
> jpa uses it to insert a row of data.
>
> Thank you.
>
> Alejandro Abdelnur wrote:
> Han Xiao, I've meant the indexes of ALL tables created by Oozie are
> missing.
>
> Please try the following using an Oozie build from a fresh checkout and
> then applying your patch and you'll see the difference:
>
> $ bin/ooziedb.sh create -sqlfile oozie.sql
>
> compare the oozie.sql obtain in both runs.
>
> thx
yes, you are right. the patch uploaded has missed a part for trim(), as you
mentioned before:
---------------------------------
we should trim the value obtained from the conf.get() here
Han Xiao 5 days, 22 hours ago (May 11th, 2012, 3:42 a.m.)
ok
---------------------------------
sorry for this happened.
- Han
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4755/#review7807
-----------------------------------------------------------
On 2012-05-17 01:51:23, Han Xiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4755/
> -----------------------------------------------------------
>
> (Updated 2012-05-17 01:51:23)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> Oozie's JPA service doesn't support configure different schemas for oozie's
> db.
> Our company wants to use one db for multi oozie clusters, and then we want
> each oozie cluster can use different schema of the db. Therefore JPAService
> in oozie should support to configure the schema of the db, not just the
> database.
> The oozie.db.schema.name is use to configure oozie's db name, however, it is
> a little confusing for it is not used to configure the actually schema of db.
>
>
> This addresses bug OOZIE-814.
> https://issues.apache.org/jira/browse/OOZIE-814
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/conf/oozie-site.xml
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/SystemInfoBean.java
> PRE-CREATION
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/java/org/apache/oozie/service/JPAService.java
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/META-INF/persistence.xml
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/core/src/main/resources/oozie-default.xml
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/docs/src/site/twiki/AG_Install.twiki
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java
> 1335881
>
> http://svn.apache.org/repos/asf/incubator/oozie/trunk/utils/dbutils/updatescripts/readme.txt
> 1335881
>
> Diff: https://reviews.apache.org/r/4755/diff
>
>
> Testing
> -------
>
> * Deployed Oozie, added oozie.db.schema.name configs values, succeed to run
> the examples on Derby and Postgres databases.
>
>
> Thanks,
>
> Han
>
>
