----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4881/#review7902 -----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/4881/#comment17212> can we have a function foo(File, String) which will write the string to the file? this will increase readability trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/4881/#comment17213> can this just have only necessary info like 'debug', '_L19_' instead of a big string?..same comment for other places trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/4881/#comment17214> is this required if the next call is close()? trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/4881/#comment17215> did u mean 2012-03-24 - Virag On 2012-04-26 00:15:30, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4881/ > ----------------------------------------------------------- > > (Updated 2012-04-26 00:15:30) > > > Review request for oozie. > > > Summary > ------- > > Oozie.log files can be gzipped by a log setting and then we work with hourly > .gz log files. For a long running job spanning multiple hours, OOZIE-590 > fixed the log retrieval issue from multiple such gz files. I'm adding a unit > test for checking this functionality. > > > This addresses bug OOZIE-821. > https://issues.apache.org/jira/browse/OOZIE-821 > > > Diffs > ----- > > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1326832 > > Diff: https://reviews.apache.org/r/4881/diff > > > Testing > ------- > > > Thanks, > > Mona > >
