----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4881/#review7966 -----------------------------------------------------------
trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java <https://reviews.apache.org/r/4881/#comment17306> USER[oozie] GROUP[-] TOKEN[-] APP[example-" + "forkjoinwf] " + "JOB[14-200904160239--example-forkjoinwf] ACTION[-] End workflow state change" This string is repeated 4-5 times here and in the previous function. Can we put it into a variable?. That would make the function look cleaner. Other than that, looks good - Virag On 2012-05-17 22:06:05, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4881/ > ----------------------------------------------------------- > > (Updated 2012-05-17 22:06:05) > > > Review request for oozie. > > > Summary > ------- > > Oozie.log files can be gzipped by a log setting and then we work with hourly > .gz log files. For a long running job spanning multiple hours, OOZIE-590 > fixed the log retrieval issue from multiple such gz files. I'm adding a unit > test for checking this functionality. > > > This addresses bug OOZIE-821. > https://issues.apache.org/jira/browse/OOZIE-821 > > > Diffs > ----- > > trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java 1338503 > > Diff: https://reviews.apache.org/r/4881/diff > > > Testing > ------- > > > Thanks, > > Mona > >
