[
https://issues.apache.org/jira/browse/OOZIE-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276905#comment-13276905
]
[email protected] commented on OOZIE-818:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4842/#review7935
-----------------------------------------------------------
Ship it!
Shwetha, gr8 job, thxs for your patience! it took me a while because I wanted
to ensure we would not run into a race-condition/deadlock while deleting coord
actions. it is not possible because coordinator commands lock on the
coordinator job id.
I'll commit this to trunk, would you please upload the final patch to JIRA and
grant license rights?
- Alejandro
On 2012-05-12 11:36:34, shwethags wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4842/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-12 11:36:34)
bq.
bq.
bq. Review request for oozie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
while calculating the action times. So, if the frequency is non-minutes(hours,
days, months), setting pause time can delete past coord actions
bq.
bq.
bq. This addresses bug OOZIE-818.
bq. https://issues.apache.org/jira/browse/OOZIE-818
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java
1337043
bq. trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1337043
bq.
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
1337043
bq.
trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordActionRemoveJPAExecutor.java
1337043
bq.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java
1337043
bq.
trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionRemoveJPAExecutor.java
1337043
bq.
bq. Diff: https://reviews.apache.org/r/4842/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. UT - TestCoordChangeXCommand
bq.
bq.
bq. Thanks,
bq.
bq. shwethags
bq.
bq.
> CoordChangeXCommand deletes past coordinator actions
> ----------------------------------------------------
>
> Key: OOZIE-818
> URL: https://issues.apache.org/jira/browse/OOZIE-818
> Project: Oozie
> Issue Type: Bug
> Reporter: Shwetha G S
> Assignee: Shwetha G S
> Priority: Critical
> Fix For: trunk
>
>
> CoordChangeXCommand.processLookaheadActions() doesn't use coord timeunit
> while calculating the action times. So, if the frequency is
> non-minutes(hours, days, months...), setting pause time can delete past coord
> actions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
